Skip to content
This repository has been archived by the owner on Dec 5, 2022. It is now read-only.

Aggregate column is not marked correctly for all countries #394

Closed
jzohrab opened this issue Aug 9, 2020 · 4 comments
Closed

Aggregate column is not marked correctly for all countries #394

jzohrab opened this issue Aug 9, 2020 · 4 comments
Labels
critical Critical issue data issue duplicate This issue or pull request already exists from-cds Transferred from https://github.com/covidatlas/coronadatascraper

Comments

@jzohrab
Copy link
Contributor

jzohrab commented Aug 9, 2020

Original issue https://github.com/covidatlas/coronadatascraper/issues/378, transferred here on Thursday Mar 26, 2020 at 09:18 GMT


e.g. AUS has one row for entire country marked as "state" which should be "country" and it has 6 rows for the states Australian Capital Territory, New South Wales, Northern Territory, Queensland, South Australia and Victoria which are blank but should be marked "state".

@jzohrab jzohrab added critical Critical issue data issue from-cds Transferred from https://github.com/covidatlas/coronadatascraper labels Aug 9, 2020
@jzohrab
Copy link
Contributor Author

jzohrab commented Aug 9, 2020

(Transferred comment)

In addition, countries like the USA have a country level count in addition to state and county, but then countries like China only have data at a province level... so I'm starting to go a little crazy with what countries to aggregate/melt!

@jzohrab
Copy link
Contributor Author

jzohrab commented Aug 9, 2020

(Transferred comment)

@sagarkulkarny hmm, you may be right about AUS, @camjc can you look into it? We should be properly setting aggregate: 'state' on both the states and the rolled up data for AUS itself.

@jzohrab
Copy link
Contributor Author

jzohrab commented Aug 9, 2020

(Transferred comment)

@mdibenigno I don't see the problem at all here. CHN clearly says aggregate: state, and so does every single CHN province -- if you want totals for all of CHN, then just take CHN.

Look at the code on the map: https://github.com/lazd/coronadatascraper/blob/master/site/map.js#L133-L160

You can see we find out what is a county, what is a state, and what is a country and choose which one to display by looking at aggregate.

@jzohrab
Copy link
Contributor Author

jzohrab commented Aug 9, 2020

(Transferred comment)

@tautme says

The aggregate labels for country total cases are not consistent. #378

image

@jzohrab jzohrab added the duplicate This issue or pull request already exists label Aug 9, 2020
@jzohrab jzohrab closed this as completed Aug 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
critical Critical issue data issue duplicate This issue or pull request already exists from-cds Transferred from https://github.com/covidatlas/coronadatascraper
Projects
None yet
Development

No branches or pull requests

1 participant