This repository has been archived by the owner on Dec 4, 2023. It is now read-only.
Port changes from trunk branch to 4.5 #179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turn on colour and warnings for easier debugging when migrating to 3.*
Actually display which patch is going to get applied before calling the patch command.
Helpful for debugging purposes
Depot tools do not like it whenever the vendor/v8 directory still exists when fetch is called.
It seems that the GYP configuration assumes that every x86/x86_64 MacOS or Linux system is using clang. State explicitly to GYP that we are not using clang whenever we are not using clang. See discussion in 6786a2c
ignisf
force-pushed
the
port-changes-from-trunk-branch
branch
from
9bfc404
to
2a545e9
Compare
ignisf
force-pushed
the
port-changes-from-trunk-branch
branch
from
1d9ff8a
to
4192cb6
Compare
Since GCCs prior to 4.8 are no longer supported, this flag is no longer needed.
Disable external startup data until it's implemented on all platforms. In libv8's case the binary size is not a major concern.
This was causing the build scripts to not detect clang++ whenever both it and an incompatible GCC were present on the system.
|
We may have to install gcc 4.8 as part of the travis build http://gearchicken.com/wordpress/?p=105 |
|
Yes. I wanted to see if the build would fall back gracefully to clang if there was an incompatible GCC. It did. |
|
Fantastic! Unless there's something else you want to accomplish here, I think it's ready to merge into the 4.5 branch. We can try and sort out the Windows build there. Also, I wonder if we could speed up build times by having the Chromium |
cowboyd
added a commit
that referenced
this pull request
Jul 6, 2015
Port changes from trunk branch to 4.5
|
@ignisf Way to bulldoze all the problem things! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.