Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support viem #188

Open
devanoneth opened this issue Dec 15, 2023 · 0 comments
Open

Support viem #188

devanoneth opened this issue Dec 15, 2023 · 0 comments

Comments

@devanoneth
Copy link

devanoneth commented Dec 15, 2023

viem is gaining traction over ethers. I think it would be beneficial for SDK adoption to support both ethers and viem.

You could accept a viem walletClient or account as well as an ethers Signer for order signing: https://github.com/cowprotocol/cow-sdk/blob/main/src/order-signing/utils.ts

This could either be done via function overloading or new functions directly.

I guess it's also worth considering then publishing a separate ethers or viem cow-sdk package because I see the SDK is currently referencing ethers as a peer dependency.

If you can comment some pointers on which design you'd prefer, I'd be happy to open a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant