Inefficiency in FakeSMCDevice::getKey

[RehabMan]

Just something I noticed while merging in some of your recent changes. You are using snprintf inside the loop to space-pad the passed in 'name' to getKey:

   while ((key = OSDynamicCast(FakeSMCKey, iterator->getNextObject()))) {

            // Made the key name valid (4 char long): add trailing spaces if needed
            char validKeyNameBuffer[5];
            snprintf(validKeyNameBuffer, 5, "%-4s", name);

            ...

Since 'name' is invariant, the creation of validKeyNameBuffer can be moved outside the loop for efficiency:

   // Made the key name valid (4 char long): add trailing spaces if needed
   char validKeyNameBuffer[5];
   snprintf(validKeyNameBuffer, 5, "%-4s", name);

   while ((key = OSDynamicCast(FakeSMCKey, iterator->getNextObject()))) {

             ...

[CozmoNate]

Yes, thank you, fixed.