Add custom suffix to conflict name #1425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit e6f9721. This fix was not usable because we can not know every possible format regex. So it is not usable in the real world. BREAKING CHANGE: It is not possible anymore to pass a name format regex to generateNewFileNameOnConflict
Check if there are _X inside AND at the end of a filename, that at the end it gets correctly incremented.
Sometimes, files are named like they already had a conflict like IMG_001.JPG. It is a normal name but in this case, previous implementation would consider _001 as a conflict suffix and would return IMG_2.JPG whereas we expect IMG_001_1.JPG. By allowing to pass a custom delimiter, we can avoid this issue by renaming during a conflict IMG_001 for example to IMG_001_cozy1.jpg. So no more issues due to '_' confusion.
zatteo
requested review from
Crash--,
Merkur39 and
paultranvan
as code owners
Crash--
approved these changes
Nov 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.