Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testcafe : Create empty album scenario #1460

Merged
merged 1 commit into from Mar 1, 2019

Conversation

CozyKourai
Copy link
Contributor

@CozyKourai CozyKourai commented Feb 21, 2019

this PR will need rebase after #1453 is merge

feat(testcafe): Create empty album scenario is the 'real' commit for this PR.

feat(testcafe) : Photo album full #1453 is just getting the changes from PR1453 as the changes are needed to run this PR

@CozyKourai CozyKourai marked this pull request as ready for review February 21, 2019 13:46
@cozy-bot
Copy link

🎁 Click here to download the latest Android APK

1 similar comment
@cozy-bot
Copy link

🎁 Click here to download the latest Android APK

@cozy-bot
Copy link

🎁 Click here to download the latest Android APK

@cozy-bot
Copy link

🎁 Click here to download the latest Android APK

@cozy-bot
Copy link

🎁 Click here to download the latest Android APK

@cozy-bot
Copy link

🎁 Click here to download the latest Android APK

@CozyKourai CozyKourai force-pushed the testcafe/photos_album_empty branch 2 times, most recently from 6655686 to d3edf69 Compare February 25, 2019 09:10
@cozy-bot
Copy link

🎁 Click here to download the latest Android APK

@cozy-bot
Copy link

🎁 Click here to download the latest Android APK

@cozy-bot
Copy link

🎁 Click here to download the latest Android APK

@CozyKourai CozyKourai force-pushed the testcafe/photos_album_empty branch 2 times, most recently from bfeffc5 to 991173b Compare February 25, 2019 10:37
@cozy-bot
Copy link

🎁 Click here to download the latest Android APK

@cozy-bot
Copy link

🎁 Click here to download the latest Android APK

@CozyKourai
Copy link
Contributor Author

@cozy-bot
Copy link

🎁 Click here to download the latest Android APK

@cozy-bot
Copy link

cozy-bot commented Mar 1, 2019

🎁 Click here to download the latest Android APK

@cozy-bot
Copy link

cozy-bot commented Mar 1, 2019

🎁 Click here to download the latest Android APK

Copy link
Contributor

@y-lohse y-lohse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay, LGTM !

Copy link
Contributor

@Crash-- Crash-- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@CozyKourai CozyKourai merged commit e1e1b85 into master Mar 1, 2019
@CozyKourai CozyKourai deleted the testcafe/photos_album_empty branch March 1, 2019 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants