feature(testcafe): viewer public drive #1507

CozyKourai · 2019-03-20T11:28:31Z

new folder drive-vr containing page model, to use with visual testing :
Some test function were modified to fit with visual review, and I didn't want to check the old tests which don't use Visual Review. In the future(?) all page model should move to drive-vr or photos-vr when all tests use Visual Review
also all methods which take a screenshot are now named method_vr()

cozy-bot · 2019-03-20T11:51:13Z

Visual Review - Please review screenshots, then restart build.

❌ drive : PublicViewerFeature 1- Prepare Data : https://visualreview.cozycloud.cc/#/31/54/680

❌ drive : PublicViewerFeature 2- Go to public link and download files : https://visualreview.cozycloud.cc/#/31/55/681

❌ drive : PublicViewerFeature 3- Cleanup Data : https://visualreview.cozycloud.cc/#/31/56/682

cozy-bot · 2019-03-20T13:26:45Z

Visual Review - Please review screenshots, then restart build.

❌ undefined : fixture : upload photos : https://visualreview.cozycloud.cc/#/32/57/683

❌ undefined : fixture : delete photos : https://visualreview.cozycloud.cc/#/32/58/684

cozy-bot · 2019-03-20T14:52:17Z

Visual Review - Please review screenshots, then restart build.

❌ drive : PublicViewerFeature 1- Prepare Data : https://visualreview.cozycloud.cc/#/31/54/708

❌ drive : PublicViewerFeature 2- Go to public link and download files : https://visualreview.cozycloud.cc/#/31/55/709

cozy-bot · 2019-03-20T14:57:06Z

Visual Review - Please review screenshots, then restart build.

❌ photos : fixture : upload photos : https://visualreview.cozycloud.cc/#/34/61/712

cozy-bot · 2019-03-21T07:56:13Z

Visual Review - Please review screenshots, then restart build.

❌ drive : PublicViewerFeature 1- Prepare Data : https://visualreview.cozycloud.cc/#/31/54/760

❌ drive : PublicViewerFeature 2- Go to public link and download files : https://visualreview.cozycloud.cc/#/31/55/761

❌ drive : PublicViewerFeature 3- Cleanup Data : https://visualreview.cozycloud.cc/#/31/56/762

cozy-bot · 2019-03-21T09:36:56Z

Visual Review - Please review screenshots, then restart build.

❌ drive : PublicViewerFeature 1- Prepare Data : https://visualreview.cozycloud.cc/#/31/54/780

❌ drive : PublicViewerFeature 2- Go to public link and download files : https://visualreview.cozycloud.cc/#/31/55/781

cozy-bot · 2019-03-21T09:52:47Z

Visual Review - Please review screenshots, then restart build.

❌ drive : PublicViewerFeature 1- Prepare Data : https://visualreview.cozycloud.cc/#/31/54/789

❌ drive : PublicViewerFeature 2- Go to public link and download files : https://visualreview.cozycloud.cc/#/31/55/791

cozy-bot · 2019-03-21T10:21:02Z

Visual Review - Please review screenshots, then restart build.

❌ drive : PublicViewerFeature 1- Prepare Data : https://visualreview.cozycloud.cc/#/31/54/804

❌ drive : PublicViewerFeature 2- Go to public link and download files : https://visualreview.cozycloud.cc/#/31/55/805

CozyKourai · 2019-03-21T13:05:42Z

(𝐒) SCN - viewer Drive - vue publique

cozy-bot · 2019-03-21T13:20:35Z

Visual Review - Please review screenshots, then restart build.

❌ drive : PublicViewerFeature 2- Go to public link and download files : https://visualreview.cozycloud.cc/#/31/55/828

cozy-bot · 2019-03-22T10:09:11Z

Visual Review - Please review screenshots, then restart build.

❌ drive : PublicViewerFeature 1- Prepare Data : https://visualreview.cozycloud.cc/#/31/54/911

❌ drive : PublicViewerFeature 2- Go to public link and download files : https://visualreview.cozycloud.cc/#/31/55/913

❌ drive : PublicViewerFeature 3- Cleanup Data : https://visualreview.cozycloud.cc/#/31/56/914

testcafe/tests/pages/drive-model-public.js

Crash-- · 2019-03-22T10:37:28Z

testcafe/tests/pages/drive-vr/drive-model.js

+
+    await this.waitForLoading()
+    console.log(`Navigation into ${folderName} OK!`)
+  }


Je serais plus pour diviser la méthode côté page-drive en 2. Car en soit, le goToFolder n'a pas à vérifier le breadcrumb... Le découpage des responsabilités est important

(à faire dans une autre PR, mais je note ça là quand même)

Crash-- · 2019-03-22T10:39:31Z

testcafe/tests/pages/drive-vr/drive-model.js

+        new RegExp('([' + numOfFiles + '].*){2}'),
+        'Numbers of files uploaded does not match'
+      )
+  }


Idem découpler dans la page drive le fait de prendre le screenshot et le expect sur les nombres de fichier.

Par contre, je comprends pas ici pourquoi on fait tout ça ? On a juste besoin d'uploader les fichiers et faire un screenshot à la fin ? Pourquoi vérifier le contenu des H4 des modales etc ?

Ces fonctions (Vérifier les modales, etc...) etaient deja en place avant l'ajout de VR, et je ne les ai pas enlevé pour pouvoir prendre le screenshot au bon moment.
Notament quand j'upload 25 fichiers à la suite : remplacer ces checks par un wait me semble plus propice à des erreurs
Par contre, c'est vrai que le execpt sur le texte peut etre retiré!

Crash-- · 2019-03-22T10:41:37Z

testcafe/tests/pages/drive-vr/drive-model.js

+  async goToFolder(folderName) {
+    await t
+      .expect(this.folderOrFileName.withText(folderName).exists)
+      .ok(`No folder named ${folderName}`)


On n'a pas besoin de ce expect, non ?

Ca reste dans les bonnes pratiques de testcafe de verifier l'existance d'un composant avant de l'utiliser (ici pour cliquer dessus)

cozy-bot · 2019-03-22T10:43:29Z

Visual Review - Please review screenshots, then restart build.

❌ drive : PublicViewerFeature 1- Prepare Data : https://visualreview.cozycloud.cc/#/31/54/920

❌ drive : PublicViewerFeature 2- Go to public link and download files : https://visualreview.cozycloud.cc/#/31/55/921

❌ drive : PublicViewerFeature 3- Cleanup Data : https://visualreview.cozycloud.cc/#/31/56/922

testcafe/tests/pages/drive-vr/public-viewer-model.js

Crash--

Ping moi quand t'es dispo, je pense qu'il y a beaucoup de taff à faire sur cette PR encore :/

cozy-bot · 2019-03-27T07:57:15Z

Visual Review - Please review screenshots, then restart build.

❌ drive : PublicViewerFeature 1- Prepare Data : https://visualreview.cozycloud.cc/#/31/54/1173

y-lohse

Thanks! I think overall the changes look good, but there are some small problems.

testcafe/runner-drive.js

testcafe/tests/drive/navigation.js

testcafe/tests/drive/public-viewer-feature.js

testcafe/tests/pages/drive-viewer/drive-viewer-model.js

testcafe/tests/pages/drive/drive-model-private.js

y-lohse · 2019-03-28T10:04:59Z

testcafe/tests/photos/photos_start_upload_photos.js

  ///there is no photos on page
  await page.initPhotoCountZero()
  await page.uploadPhotos([`${DATA_PATH}/${IMG0}`])

-  await t.fixtureCtx.vr.takeScreenshotAndUpload('Upload-1-pic.png')
+  await t.fixtureCtx.vr.takeScreenshotAndUpload('UploadImage/Upload-1-pic.png')


How comes sometimes we do if (t.fixtureCtx.isVR) before taking a screenshot, and sometimes not?

if (t.fixtureCtx.isVR)is use in methods that were written before using VisualReview, so we don't have to duplicate them (ie : UploadFiles is used in several tests : some already using VisualReview, and older tests which don't have screenshot yet, so we need a condition to know when to take screenshots)

Here, in photos_start_upload_photos.js we are in a test using VisualReview (as we do await initVR(..) in .before so we don't need to check the condition

Ok I see, temporary code then. Thanks for the explanation!

y-lohse · 2019-03-28T10:08:24Z

Just a side-question: why are the files in /pages called model?

CozyKourai · 2019-03-28T11:01:06Z

Just a side-question: why are the files in /pages called model?

Testcafe vocabulary (but we can change the name if we prefer)
https://devexpress.github.io/testcafe/documentation/recipes/use-page-model.html

y-lohse · 2019-03-28T11:39:23Z

Testcafe vocabulary (but we can change the name if we prefer)

Thanks! I now realize I may have asked this before :'). It's really confusing to me but if it's a convention I'm happy to keep it. Just might ask the same question in 3 month 😁

cozy-bot · 2019-03-28T16:22:59Z

Visual Review - Please review screenshots, then restart build.

❌ drive : PublicViewerFeature 2- Go to public link and download files : https://visualreview.cozycloud.cc/#/31/55/1321

cozy-bot · 2019-03-29T09:13:01Z

Visual Review - Please review screenshots, then restart build.

❌ drive : PublicViewerFeature 1- Prepare Data : https://visualreview.cozycloud.cc/#/31/54/1351

❌ drive : PublicViewerFeature 3- Cleanup Data : https://visualreview.cozycloud.cc/#/31/56/1352

cozy-bot · 2019-03-29T10:57:19Z

Visual Review - Please review screenshots, then restart build.

❌ drive : PublicViewerFeature 2- Go to public link and download files : https://visualreview.cozycloud.cc/#/31/55/1361

cozy-bot · 2019-03-29T12:50:15Z

Visual Review - Please review screenshots, then restart build.

❌ drive : PublicViewerFeature 2- Go to public link and download files : https://visualreview.cozycloud.cc/#/31/55/1380

cozy-bot · 2019-03-29T15:46:45Z

Visual Review - Please review screenshots, then restart build.

❌ drive : PublicViewerFeature 2- Go to public link and download files : https://visualreview.cozycloud.cc/#/31/55/1406

y-lohse

Thanks, LGTM!

CozyKourai force-pushed the testcafe/drive_public_viewer branch 2 times, most recently from a32e0e6 to c15c4c4 Compare March 20, 2019 13:58

cozy deleted a comment from cozy-bot Mar 20, 2019

cozy deleted a comment from cozy-bot Mar 21, 2019

CozyKourai force-pushed the testcafe/drive_public_viewer branch from 120a874 to c724512 Compare March 21, 2019 09:40

CozyKourai force-pushed the testcafe/drive_public_viewer branch from c724512 to 86cbec3 Compare March 21, 2019 09:58

CozyKourai force-pushed the testcafe/drive_public_viewer branch 3 times, most recently from 8eaf3e3 to 2fc0cda Compare March 22, 2019 09:47

CozyKourai force-pushed the testcafe/drive_public_viewer branch from 2fc0cda to c4cdd56 Compare March 22, 2019 10:20

Crash-- reviewed Mar 22, 2019

View reviewed changes

testcafe/tests/pages/drive-vr/public-viewer-model.js Outdated Show resolved Hide resolved

Crash-- suggested changes Mar 22, 2019

View reviewed changes

CozyKourai force-pushed the testcafe/drive_public_viewer branch from c4cdd56 to 7138aa1 Compare March 22, 2019 15:41

CozyKourai mentioned this pull request Mar 27, 2019

WIP Testcafe : Mutualize class #1522

Closed

3 tasks

CozyKourai added a commit that referenced this pull request Mar 27, 2019

feature(testcafe): viewer public drive (#1507)

3d454ad

y-lohse suggested changes Mar 28, 2019

View reviewed changes

CozyKourai force-pushed the testcafe/drive_public_viewer branch from 998d6fd to 5afa2c4 Compare March 28, 2019 11:25

CozyKourai force-pushed the testcafe/drive_public_viewer branch from 5afa2c4 to 9e70fa8 Compare March 28, 2019 12:42

CozyKourai force-pushed the testcafe/drive_public_viewer branch 2 times, most recently from a8ae69c to 52b9f9d Compare March 29, 2019 08:46

cozy deleted a comment from cozy-bot Mar 29, 2019

CozyKourai added 6 commits March 29, 2019 12:22

feature(testcafe): viewer public drive

de1f2b0

refator: extend class

7b889d5

refactor: extend viewer and move files

589940b

fix: update mask

1c47d01

fix: add hover for mobile screenshots

1438777

fix: requested in review

6112d78

CozyKourai force-pushed the testcafe/drive_public_viewer branch from fb6418a to 6112d78 Compare March 29, 2019 12:28

CozyKourai force-pushed the testcafe/drive_public_viewer branch from 3951383 to 43a688a Compare March 29, 2019 15:24

fix: change resize for viewer txt

635a72b

CozyKourai force-pushed the testcafe/drive_public_viewer branch from 43a688a to 635a72b Compare March 29, 2019 15:25

y-lohse approved these changes Mar 29, 2019

View reviewed changes

CozyKourai merged commit df0b6e9 into master Apr 1, 2019

CozyKourai deleted the testcafe/drive_public_viewer branch April 1, 2019 06:53

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feature(testcafe): viewer public drive #1507

feature(testcafe): viewer public drive #1507

CozyKourai commented Mar 20, 2019

cozy-bot commented Mar 20, 2019

cozy-bot commented Mar 20, 2019

cozy-bot commented Mar 20, 2019

cozy-bot commented Mar 20, 2019

cozy-bot commented Mar 21, 2019

cozy-bot commented Mar 21, 2019

cozy-bot commented Mar 21, 2019

cozy-bot commented Mar 21, 2019

CozyKourai commented Mar 21, 2019

cozy-bot commented Mar 21, 2019

cozy-bot commented Mar 22, 2019

Crash-- Mar 22, 2019

Crash-- Mar 22, 2019

CozyKourai Mar 22, 2019 •

edited

Crash-- Mar 22, 2019

CozyKourai Mar 22, 2019

cozy-bot commented Mar 22, 2019

Crash-- left a comment

cozy-bot commented Mar 27, 2019

y-lohse left a comment

y-lohse Mar 28, 2019

CozyKourai Mar 28, 2019

y-lohse Mar 29, 2019

y-lohse commented Mar 28, 2019

CozyKourai commented Mar 28, 2019 •

edited

y-lohse commented Mar 28, 2019

cozy-bot commented Mar 28, 2019

cozy-bot commented Mar 29, 2019

cozy-bot commented Mar 29, 2019

cozy-bot commented Mar 29, 2019

cozy-bot commented Mar 29, 2019

y-lohse left a comment

feature(testcafe): viewer public drive #1507

feature(testcafe): viewer public drive #1507

Conversation

CozyKourai commented Mar 20, 2019

cozy-bot commented Mar 20, 2019

cozy-bot commented Mar 20, 2019

cozy-bot commented Mar 20, 2019

cozy-bot commented Mar 20, 2019

cozy-bot commented Mar 21, 2019

cozy-bot commented Mar 21, 2019

cozy-bot commented Mar 21, 2019

cozy-bot commented Mar 21, 2019

CozyKourai commented Mar 21, 2019

cozy-bot commented Mar 21, 2019

cozy-bot commented Mar 22, 2019

Crash-- Mar 22, 2019

Choose a reason for hiding this comment

Crash-- Mar 22, 2019

Choose a reason for hiding this comment

CozyKourai Mar 22, 2019 • edited

Choose a reason for hiding this comment

Crash-- Mar 22, 2019

Choose a reason for hiding this comment

CozyKourai Mar 22, 2019

Choose a reason for hiding this comment

cozy-bot commented Mar 22, 2019

Crash-- left a comment

Choose a reason for hiding this comment

cozy-bot commented Mar 27, 2019

y-lohse left a comment

Choose a reason for hiding this comment

y-lohse Mar 28, 2019

Choose a reason for hiding this comment

CozyKourai Mar 28, 2019

Choose a reason for hiding this comment

y-lohse Mar 29, 2019

Choose a reason for hiding this comment

y-lohse commented Mar 28, 2019

CozyKourai commented Mar 28, 2019 • edited

y-lohse commented Mar 28, 2019

cozy-bot commented Mar 28, 2019

cozy-bot commented Mar 29, 2019

cozy-bot commented Mar 29, 2019

cozy-bot commented Mar 29, 2019

cozy-bot commented Mar 29, 2019

y-lohse left a comment

Choose a reason for hiding this comment

CozyKourai Mar 22, 2019 •

edited

CozyKourai commented Mar 28, 2019 •

edited