Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Launch each tests in a different runner #1699

Merged
merged 1 commit into from May 28, 2019
Merged

fix: Launch each tests in a different runner #1699

merged 1 commit into from May 28, 2019

Conversation

CozyKourai
Copy link
Contributor

@CozyKourai CozyKourai commented May 21, 2019 •
edited

Vérifier si les résultats de tests sur travis sont plus stables et cohérants en lancant un runner par scenario au lieu d'un seul runner jouant tous les scénarios

@cozy-bot
Copy link

Visual Review - Please review screenshots, then restart build.

  • ❌ photos : PhotosDelete 1- Delete Photos : https://visualreview.cozycloud.cc/#/1/7/1547

    		•

    @cozy-bot
    Copy link

    Visual Review - Please review screenshots, then restart build.

  • ❌ drive : Cleanup Data : https://visualreview.cozycloud.cc/#/2/43/1549

    		•

    @CozyKourai
    Copy link
    Contributor Author

    Runner : new runner for each Scenario on travis

    @cozy-bot
    Copy link

    Visual Review - Please review screenshots, then restart build.

  • ❌ drive : PublicViewerFeature 1- Prepare Data : https://visualreview.cozycloud.cc/#/2/8/1643
  • ❌ drive : PublicViewerFeature 2- Go to public link and download files : https://visualreview.cozycloud.cc/#/2/9/1644
  • ❌ drive : Search : https://visualreview.cozycloud.cc/#/2/49/1646
  • ❌ drive : Cleanup Data : https://visualreview.cozycloud.cc/#/2/43/1647

    		•

    @cozy-bot
    Copy link

    🎁 Click here to download the latest Android APK

    @cozy-bot
    Copy link

    Visual Review - Please review screenshots, then restart build.

  • ❌ photos : CreateFullAlbumScenario 1- Create Full Album : https://visualreview.cozycloud.cc/#/1/4/166

    		•

    @cozy-bot
    Copy link

    Visual Review - Please review screenshots, then restart build.

  • ❌ drive : Search : https://visualreview.cozycloud.cc/#/2/5/170

    		•

    @cozy-bot
    Copy link

    Visual Review - Please review screenshots, then restart build.

  • ❌ drive : Search : https://visualreview.cozycloud.cc/#/2/5/217

    		•

    @cozy-bot
    Copy link

    Visual Review - Please review screenshots, then restart build.

  • ❌ drive : Search : https://visualreview.cozycloud.cc/#/2/5/308

    		•

    @cozy-bot
    Copy link

    Visual Review - Please review screenshots, then restart build.

  • ❌ drive : Search : https://visualreview.cozycloud.cc/#/2/5/349

    		•

    @Crash--
    Copy link
    Contributor

    Crash-- commented May 27, 2019

    ça donne quoi cette PR ?

    Est-ce qu'on a de la stabilité en plus ? Du gain en terme de durée sur le test complet ?

    @CozyKourai
    Copy link
    Contributor Author

    C'est pas mal, meme avec les anciens timeouts elle tourne plutot bien : j'ai pas eu de fail random dessus pour le moment

    @cozy-bot
    Copy link

    Visual Review - Please review screenshots, then restart build.

  • ❌ drive : Search : https://visualreview.cozycloud.cc/#/2/5/517

    		•

    @CozyKourai CozyKourai changed the title [WIP] fix: Launch each tests in a different runner fix: Launch each tests in a different runner May 28, 2019
    @CozyKourai CozyKourai requested review from Crash-- and y-lohse and removed request for Crash-- May 28, 2019 13:33
    @CozyKourai
    Copy link
    Contributor Author

    All test runs were succesfull with this PR

    Crash--
    Crash-- approved these changes May 28, 2019
    View reviewed changes
    Copy link
    Contributor

    @Crash-- Crash-- left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Le fait de convertir en tableau ça change rien du tout : https://github.com/DevExpress/testcafe/blob/master/src/runner/index.js#L314 vu que testcafé aplati l'array. Donc on a bien la même chose au final.

    Le seul avantage de cette PR est donc le runAllTests() qui apporte un peu de refacto.

    @CozyKourai CozyKourai merged commit ef19de2 into master May 28, 2019
    @CozyKourai CozyKourai deleted the testcafe/onerunner branch May 28, 2019 13:55
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @Crash-- Crash-- Crash-- approved these changes

    @y-lohse y-lohse Awaiting requested review from y-lohse

    Assignees
    No one assigned
    Labels
    None yet
    Projects
    None yet
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.

    None yet
    3 participants
    @CozyKourai @cozy-bot @Crash--