feat: enhance offline behavior #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kosssi
reviewed
Mar 13, 2017
mobile/src/lib/cozy-helper.js
Outdated
| @@ -22,7 +24,7 @@ export const initClient = (url, onRegister = null, device = 'Device') => { | |||
| console.log(`Cozy Client initializes a connection with ${url}`) | |||
| cozy.client.init({ | |||
| cozyURL: url, | |||
| offline: {doctypes: ['io.cozy.files']}, | |||
| // offline: {doctypes: ['io.cozy.files']}, | |||
There was a problem hiding this comment.
Oh, yes, yet another too early push.
kosssi
reviewed
Mar 13, 2017
mobile/src/lib/cozy-helper.js
Outdated
| if (result.docs_written !== 0) { | ||
| dispatch(openFolder(getState().folder.id)) | ||
| } | ||
| console.log('replication complete', result) |
There was a problem hiding this comment.
It's normal to have left the log?
There was a problem hiding this comment.
Oh no, I missed it... again! ;)
|
@enguerran can you rebase & upgrade cozy-client-js? |
|
This branch is up-to-date, I need to double-check the behavior before a potential merge. |
|
According to me, it works like a charm. |
|
As soon as @kosssi validates the changes, I merge it. |
goldoraf
pushed a commit
to goldoraf/cozy-drive
that referenced
this pull request
Aug 21, 2017
fix: clear selection on view change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a replication is complete AND when there is some new document(s), then
we refresh the current folder's file list by dispatching an action creator.
And on startup, we don't get localfile first as in that case we have to need the end of the replication to display files.
Instead we load remote files and start a repeated replication. When the first replication is going to start, it creates a local database.
It is related to cozy/cozy-client-js#109
I think it's better, what do you think?