Skip to content

Commit

Permalink
fix: QualificationListItemInformation component
Browse files Browse the repository at this point in the history
The value of an information metadata can be of type number
(cf: `refTaxIncome` in `tax_notice` qualification label)
  • Loading branch information
Merkur39 committed Mar 21, 2023
1 parent 8347cd6 commit 2698d9f
Show file tree
Hide file tree
Showing 2 changed files with 14 additions and 5 deletions.
7 changes: 3 additions & 4 deletions react/Viewer/Panel/QualificationListItemInformation.jsx
Expand Up @@ -14,7 +14,7 @@ import { useI18n } from '../../I18n'
import MidEllipsis from '../../MidEllipsis'

export const makeInformationValue = ({ name, value, t, scannerT }) => {
if (!value) {
if (typeof value !== 'number' && !value) {
return t('Viewer.panel.qualification.noInfo')
}

Expand All @@ -23,12 +23,11 @@ export const makeInformationValue = ({ name, value, t, scannerT }) => {
smart_count: value
})}`
}

if (name === 'contractType') {
return scannerT(`Scan.attributes.contractType.${value}`)
}

return <MidEllipsis text={value} />
return <MidEllipsis text={`${value}`} />
}

const QualificationListItemInformation = forwardRef(
Expand Down Expand Up @@ -72,7 +71,7 @@ QualificationListItemInformation.displayName = 'QualificationListItemNumber'
QualificationListItemInformation.propTypes = {
formatedMetadataQualification: PropTypes.shape({
name: PropTypes.string,
value: PropTypes.string
value: PropTypes.oneOfType([PropTypes.string, PropTypes.number])
}).isRequired,
toggleActionsMenu: PropTypes.func.isRequired
}
Expand Down
12 changes: 11 additions & 1 deletion react/Viewer/Panel/QualificationListItemInformation.spec.jsx
Expand Up @@ -25,7 +25,7 @@ const setup = ({
}

describe('QualificationListItemInformation', () => {
describe('formatedMetadataQualification', () => {
fdescribe('formatedMetadataQualification', () => {
it('should display default text if value is falsy', () => {
const formatedMetadataQualification = { name: 'country', value: '' }
const { getByText } = setup({ formatedMetadataQualification })
Expand All @@ -39,6 +39,16 @@ describe('QualificationListItemInformation', () => {
})

expect(queryByText('Viewer.panel.qualification.noInfo')).toBeNull()
expect(queryByText('Ita')).toBeInTheDocument()
})
it('should display current value if it number type', () => {
const formatedMetadataQualification = { name: 'country', value: 0 }
const { queryByText } = setup({
formatedMetadataQualification
})

expect(queryByText('Viewer.panel.qualification.noInfo')).toBeNull()
expect(queryByText('0')).toBeInTheDocument()
})
})
describe('toggleActionsMenu', () => {
Expand Down

0 comments on commit 2698d9f

Please sign in to comment.