Skip to content

Commit

Permalink
feat(Viewer): Changing the behavior of the edit action
Browse files Browse the repository at this point in the history
We no longer want the action to gray out the URL
generation time, because this time is generally short
and generates an unpleasant flicker.
  • Loading branch information
Merkur39 committed Feb 13, 2024
1 parent 96c4ebf commit 3308336
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 9 deletions.
9 changes: 1 addition & 8 deletions react/Viewer/Panel/ActionMenuDesktop.jsx
Expand Up @@ -25,14 +25,7 @@ const ActionMenuDesktop = forwardRef(
<AppLinker app={{ slug: appSlug }} href={appLink}>
{({ onClick, href }) => {
return (
<a
href={href}
className={
!appLink &&
styles['ActionMenuDesktop-ActionMenu-link-disabled']
}
onClick={() => handleEdit(onClick)}
>
<a href={href} onClick={() => handleEdit(onClick)}>
<ActionMenuItem left={<Icon icon={Edit} />}>
<Typography>
{t(`Viewer.panel.qualification.actions.edit`)}
Expand Down
1 change: 0 additions & 1 deletion react/Viewer/Panel/ActionMenuMobile.jsx
Expand Up @@ -35,7 +35,6 @@ const ActionMenuMobile = ({
component="a"
href={href}
onClick={() => handleEdit(onClick)}
disabled={!appLink}
>
<ListItemIcon>
<Icon icon={Edit} />
Expand Down

0 comments on commit 3308336

Please sign in to comment.