-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option to install ReShade shaders #2
Comments
Oh wow, thank you for bringing all of this together, this really makes my work a lot easier. I will probably get around to adding ReShade shaders either later today or some time during next week c: And like last issue, I agree with all of your points. We will most likely go down the same route the installer script uses:
I wanted to do the INI part from the start, but I didn't have a good grasp on what a default INI looked like. For git, I will probably end up using git2, since those are bindings to libgit2. If someone doesn't have libgit2 installed on their PC, the build script for git2 will compile it for them, or so the page of the crate says. Although one improvement which could be done for the INI is to add the |
It seems that the default it picks for So if we wanted to be in line with that we could use If modifying with sane defaults / being more in line with what gshade's defaults were, I'd also add that |
I wouldn't put them into And your file naming default is good, ReShade's I'd love if you could specify these variables in the save path, so ReShade would save screenshots into a folder called |
I mentioned As for file name, if we're going to add the AppName may I propose having the AppName first then? I.e. Definitely agree that being able to specify at least the
But I don't entirely trust the parameter quoting that the arguments variable will do, nor do I think it'll be as simple to just fork to a real Linux program from the wine run... I guess you could install into the directory a windows build and call that, or make a super simple program that just does the file system moves and nothing else. Honestly at that point probably easier to just setup a daemon watching the screenshot directory that asynchronously takes a |
Unrelated to this issue directly, but since Probably needs some change to an external facing documentation so that mouse over details you can use those macros like the way the other settings do currently, but getting the macro itself to work should be as simple as that. Would be a decently quick PR to make I guess, given being able to build ReShade easily in the first place haha. EDIT: That being said looking at the code... |
Hey again, just wanted to let you know that it seems like at least some preset/shader authors in the community (and probably all of them as time goes forward) are gearing their new releases around the assumption that the user just straight installed ReShade 5.6 while checking all the "install shaders" options. I.e. there's an assumption that
reshade-shaders
has everything in it that a normal ReShade 5.6 install would have (and only those to an extent).As I've found, however, what GShade had is not necessarily the same as the above and so you may run into weird and exciting breakages from those differences.
So with that in mind, future-proofing wise it may be desirable to be able to only install the base
reshade-shaders
as done by the ReShade installation process. From here: https://github.com/kevinlekiller/reshade-steam-proton/blob/main/reshade-linux.sh#L305It seems like a full installation wherein you checked all the optional shaders has the following repos merged into one
reshade-shaders/{Shaders,Textures}
, with some of the optional extras as sub-folders for theShaders/
case.I got a friend on Windows to do a fresh install to confirm the directory structure and at least by default it seems that
reshade-shaders/Shaders
does the following:Shaders
in their respective git repos are copied directly toreshade-shaders/Shaders
for the following:Shaders
in their respective git repos are copied into a subdirectory withinreshade-shaders/Shaders
for the following:reshade-shaders/Shaders/qUINT/
reshade-shaders/Shaders/AstrayFX
(including another subdirectOneShot
as in the repo)reshade-shaders/Shaders/PD80/
The
Textures
directory remains flat, just a direct copy of allTextures/
folders from the above five repos.If you wanted to be really fancy, as they're all git repositories, you could optionally depend upon
git
andgit clone <url>
all five of those repos (perhaps as shallow copies on first install), symlink them into the merged structure (as the kevinlekiller script does), and then use that structure accordingly. That way update operations can be as simple asgit pull
on all of them (or be even more fancy and setup the download area as a git repo that those 5 are subrepos of and then use a submodule recursive update to do all of them, that seems like overkill though).Alternatively just straight zip download as per usual of course.
As a plus to all this, all involved repositories don't have asinine unenforceable provisions against downloading them, and some of them are even open source, so this can be automated.
Oh also as an additional bonus, here's the full text of the default
ReShade.ini
configuration file created for this type of installation (the subdirectories inreshade-shaders/Shaders
are included explicitly rather than by using a wildcard catch all)The text was updated successfully, but these errors were encountered: