Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove whitespace before Firmware Info #2

Closed
LewisSpring opened this issue Oct 4, 2020 · 6 comments
Closed

Remove whitespace before Firmware Info #2

LewisSpring opened this issue Oct 4, 2020 · 6 comments
Projects
Milestone

Comments

@LewisSpring
Copy link

LewisSpring commented Oct 4, 2020

Hi there, thanks for taking over the plugin.

I've found an issue to query you about:
image

There is a large amount of whitespace in front of the Firmware Info output.

Thanks!

@cp2004
Copy link
Owner

cp2004 commented Oct 4, 2020

I am aware of this one, still trying to dig through the code to understand why it appears! It will be fixed at some point.

@cp2004 cp2004 added this to the 2.0.0 milestone Oct 4, 2020
@LewisSpring
Copy link
Author

I am aware of this one, still trying to dig through the code to understand why it appears! It will be fixed at some point.

Great. Thanks!

cp2004 added a commit that referenced this issue Oct 5, 2020
@cp2004
Copy link
Owner

cp2004 commented Oct 5, 2020

So while I was able to reproduce this initially, when I went to analyse it to fix, I then couldn't get it to happen 🙁

Going off code analysis, I added in some bits that trim down the whitespace, at any points I think it could turn up.

At some point, please try out the development branch, by installing in 'plugin manager > get more > ...from url' then paste https://github.com/cp2004/OctoPrint-EEPROM-Marlin/archive/devel.zip and you should be on the way.

@cp2004 cp2004 added this to Fixing in Bug Triage Oct 5, 2020
@cp2004 cp2004 moved this from Fixing to Needs testing in Bug Triage Oct 5, 2020
@LewisSpring
Copy link
Author

So while I was able to reproduce this initially, when I went to analyse it to fix, I then couldn't get it to happen 🙁

Going off code analysis, I added in some bits that trim down the whitespace, at any points I think it could turn up.

At some point, please try out the development branch, by installing in 'plugin manager > get more > ...from url' then paste https://github.com/cp2004/OctoPrint-EEPROM-Marlin/archive/devel.zip and you should be on the way.

Hi there!
That's fixed it i believe, i've tried reloading a few times with no preceding whitespace.
Thanks!

@cp2004
Copy link
Owner

cp2004 commented Oct 6, 2020

Excellent news, thank you for testing it!

@cp2004
Copy link
Owner

cp2004 commented Oct 7, 2020

2.0.0 Has been released, hopefully you get the update notification

@cp2004 cp2004 closed this as completed Oct 7, 2020
Bug Triage automation moved this from Needs testing to Closed Oct 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

No branches or pull requests

2 participants