Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Request] Add TMC Support #30

Closed
rodmagno opened this issue Feb 11, 2021 · 7 comments
Closed

[Request] Add TMC Support #30

rodmagno opened this issue Feb 11, 2021 · 7 comments
Labels
request New feature or request solved Solved, but not yet released.
Milestone

Comments

@rodmagno
Copy link

It would be nice to have TMC drivers info and edit the values

https://marlinfw.org/docs/gcode/M122.html
https://marlinfw.org/docs/gcode/M569.html
https://marlinfw.org/docs/gcode/M906.html
https://marlinfw.org/docs/gcode/M913.html

@github-actions github-actions bot added needs review Yet to be reviewed request New feature or request labels Feb 11, 2021
@cp2004 cp2004 removed the needs review Yet to be reviewed label Feb 11, 2021
@cp2004
Copy link
Owner

cp2004 commented Feb 11, 2021

I will see what can be done. It will need testing from you when it is done - I have to extend the virtual printer for each of the commands I want to test, my printer does not have this stuff, and it doesn't always substitute for the real thing.

@rodmagno
Copy link
Author

Sure, whenever you have a snapshot, let me know and i will test it

@cp2004 cp2004 added this to the 3.1.0 milestone Feb 23, 2021
@PD5DJ
Copy link

PD5DJ commented Feb 23, 2021

Would indeed be a great implementation :-)

@cp2004 cp2004 added this to Backlog in Feature Request triage Mar 15, 2021
@cp2004
Copy link
Owner

cp2004 commented May 27, 2021

Could someone here send me the M503 response from your printer? I need to implement and test the parser for these commands, some of them look more complex than the regular ones. Thank you in advance!

cp2004 added a commit that referenced this issue May 29, 2021
Single extruder, M913 and M906. The other commands will have to wait until there is a more flexible data structure in place in the future.

See #30
@cp2004
Copy link
Owner

cp2004 commented May 29, 2021

@rodmagno or @Hobby4life - I have a development build available for you to test, if you want. It has support for M906 and M913 commands. The others are more complex and will have to wait until I have a more flexible data structure involved. Additionally, it only has support for configuring this globally, there is no per-motor control implemented for the same reason.

If you want to try the build, install using the URL:

https://github.com/cp2004/OctoPrint-EEPROM-Marlin/archive/6fbf51ee35e1a0e6b678d6b6f2a2b6b57f845b0c.zip

Let me know what you think.

@cp2004 cp2004 added the solved Solved, but not yet released. label May 29, 2021
@cp2004 cp2004 moved this from Backlog to For next release in Feature Request triage May 29, 2021
@cp2004
Copy link
Owner

cp2004 commented May 29, 2021

There's also a release candidate available for testing this now: 3.1.0rc1. Feedback ticket #45 for any comments on the release. Stable release approx. 1 week depending on how the testing goes.

@cp2004 cp2004 moved this from For next release to Solved in Feature Request triage Jun 3, 2021
@cp2004
Copy link
Owner

cp2004 commented Jun 7, 2021

3.1.0 has been released

@cp2004 cp2004 closed this as completed Jun 7, 2021
Feature Request triage automation moved this from Solved to Closed Jun 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
request New feature or request solved Solved, but not yet released.
Projects
No open projects
Development

No branches or pull requests

3 participants