-
-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: Capabilities re-arranging in the Firmware Info screen #48
Comments
I am aware that this happens, the issue is that the initial data fetched over the HTTP API is somehow sorted - I didn't sort it, and I'm not sure what does, but it is something within OctoPrint's flask/tornado server implementation. The data from the button click is reported over the websocket, which apparently doesn't sort it the same way so it remains in the same order it comes out of the printer. I am not sure if I'm really interested in fixing the issue, as it requires sorting all the data as it arrives in the frontend - I would rather leave it all as it is read from the printer, but that's not an option. If someone else was to send in a PR, I would accept it but I'm not sure if I have time to work on this. As a side note, thank you very much for completely filling in the bug report template! It is helping me to gather examples of other printer communication, as I can now throw your M503 response at my install to see what it does with it if you were reporting another kind of bug. Thanks! |
The capabilities are now sorted alphabetically all the time - it was really not as hard as my response made it out to be, I was just lazy and have since learnt more JavaScript. |
There's a release candidate build available if you want to test it - switch to 'Release Candidate' channel for this plugin in the software update settings in OctoPrint. Release notes: https://github.com/cp2004/OctoPrint-EEPROM-Marlin/releases/tag/3.2.0rc1 |
3.2.0 has been released 🙂 |
Description of the bug
When pressing the "Load" button in the Firmware Info tab, the Capabilities rearrange from alphabetcial order to a seemingly random order. Expected behavior is that the capabilities remain in alphabetical order.
Plugin version
3.1.0
OctoPrint version
1.6.1
M503 Response
API Response
OctoPrint logs
octoprint.log
The text was updated successfully, but these errors were encountered: