Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move to Fortran 2008 intrinsic and remove -D__F2008 flag #142

Closed
oschuett opened this issue Dec 21, 2018 · 2 comments
Closed

Move to Fortran 2008 intrinsic and remove -D__F2008 flag #142

oschuett opened this issue Dec 21, 2018 · 2 comments

Comments

@oschuett
Copy link
Member

We now state Fortran 2008 as our default standart in the conventions. Hence we should now replace our own implementions with Fortran intrinsics were possible. The __F2008 flag is also no longer needed.

See also cp2k/dbcsr#129 .
@mkrack
Copy link
Member

mkrack commented Jan 7, 2019

The __F2008 flag has been a work around for the transition to Fortran 2008 just to keep the CP2K internal legacy routines for erf and erfc in the module erf_fn. I also suggest to discard erf_fn and to rely on the corresponding intrinsics provided by the compiler. A regression tester run with gfortran showed no numerical issues.

@mkrack
Copy link
Member

mkrack commented Jan 8, 2019

Pull request created (#158)

@dev-zero dev-zero mentioned this issue Jan 16, 2019
Merged
@mkrack mkrack closed this as completed Feb 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@oschuett @mkrack @juerghutter