Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

turn off and remove codecoverage checks #653

Closed
hfp opened this issue Feb 1, 2023 · 3 comments
Closed

turn off and remove codecoverage checks #653

hfp opened this issue Feb 1, 2023 · 3 comments

Comments

@hfp
Copy link
Member

hfp commented Feb 1, 2023

I think the code coverage checks which are part of several tests (if not all) just burn energy and are mostly useless. Nobody cares about the noise, and the project calibrated the threshold just for the status quo. I think there are other means of judging the quality of contributions (and amount of coverage was never a criterion).

Disadvantages:

  • Noise (if not e-mail notification) about missing the threshold by "0.06%".
  • Upload errors from time to time for external services like Codecov.io.
  • Contributions cannot be judged by percentage of coverage.
  • Useless (calibrated for the status quo).

Alternatives:

  • Consider runtime decision instead of compile-time decision if there is additional/user benefit.
  • Enforce documentation of preprocessor symbols like CP2K does (or whitelist).
@hfp
Copy link
Member Author

hfp commented Feb 3, 2023

Codecov.io seems to work again. I can still cause unreliability due to uploading data. Closing for now.

@hfp hfp closed this as completed Feb 3, 2023
@alazzaro alazzaro reopened this Feb 3, 2023
@alazzaro
Copy link
Member

alazzaro commented Feb 3, 2023

@hfp thanks for bringing up this discussion. I think it is still relevant, let's keep the issue open. Personally, I use to check the coverage, but I agree with you we need to revisit it...

@alazzaro
Copy link
Member

alazzaro commented Jul 5, 2023

I think @dev-zero remove the check, so I will close here.

@alazzaro alazzaro closed this as completed Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants