Generated .pyi files include __pycache__, are not idempotent

[lidavidm]

I've noticed a few things about generated .pyi files:

• __pycache__ gets picked up and imported,
• Entries are not sorted (though this isn't really a big deal, it kinda helps with reviewing the diff)
• Entries get duplicated if run multiple times/generation is not idempotent

The last one is probably harder to solve since it appears Protoletariat is not assuming it has full control of the pyi (understandable), or else it could overwrite instead of append.

[cpcloud]

Sweet, thanks for the issue. I think we can probably address all three.

The last one may be a bit tricky as you say.

Maybe inserting a comment at the end like # __protol__: $ORIGINAL_IMPORT to indicate that the line came from protol and then leaving out duplicates during rewriting would work.

[lidavidm]

Frankly a simple string match is probably enough, if janky

[cpcloud]

@lidavidm Do you have a concrete example of

__pycache__ gets picked up and imported,

I'm not seeing .pyi files inside of __pycache__ anywhere.

[lidavidm]

Oh sorry, what I mean is it'll generate things like

from . import __pycache__

inside the .pyi files if not run from a clean checkout