Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump outside of closing brackets/quote with Tab when typing #256

Closed
GoBigorGoHome opened this issue Apr 25, 2020 · 4 comments · Fixed by #380
Closed

Jump outside of closing brackets/quote with Tab when typing #256

GoBigorGoHome opened this issue Apr 25, 2020 · 4 comments · Fixed by #380
Assignees
Labels
enhancement New feature or request help wanted Harder than good first issues but not too hard for newcomers, and not assigned to any maintainer high_priority High Priority Issues are marked with this label. preferences Something related to the preferences work in progress The work has been started and is in progress.
Milestone

Comments

@GoBigorGoHome
Copy link

Is your feature request related to a problem? Please describe.
When coding, frequently I have to move the cursor outside of closing brackets/quote by pressing the right arrow key, and I find it kinda slow to do that.

Describe the solution you'd like
Implement the "Jump outside of closing brackets/quote with Tab when typing" feature for the editor.
This feature is available in Visual Studio and CLion, and also in VS Code by extension.

Describe alternatives you've considered

Additional context

@GoBigorGoHome GoBigorGoHome added the enhancement New feature or request label Apr 25, 2020
@coder3101 coder3101 added low_priority This label is for issues that have less prority for now. preferences Something related to the preferences labels Apr 25, 2020
@coder3101
Copy link
Member

This feature requests is to QCodeEditor but I will keep it here on cpeditor because when QCodeEditor adds it, this feature should get its place in new preference window.

@ouuan you can re-prioritize this issue and maybe add it as per your convenience.

@ouuan ouuan added high_priority High Priority Issues are marked with this label. and removed low_priority This label is for issues that have less prority for now. labels Apr 26, 2020
@ouuan ouuan added this to the v6.4 milestone Apr 26, 2020
@ouuan ouuan added the help wanted Harder than good first issues but not too hard for newcomers, and not assigned to any maintainer label Apr 26, 2020
@ouuan
Copy link
Member

ouuan commented Apr 26, 2020

In addition, I think it should be treated like #206, i.e. has a separate configuration for each parenthesis.

It's not hard to implement, just add checks for parentheses in these lines:

https://github.com/cpeditor/QCodeEditor/blob/7b7bf07834a23185e78a3e3582123fa6f04653b7/src/internal/QCodeEditor.cpp#L592-L604

And here's a good reference:

https://github.com/cpeditor/QCodeEditor/blob/7b7bf07834a23185e78a3e3582123fa6f04653b7/src/internal/QCodeEditor.cpp#L663-L693

@ouuan ouuan assigned ouuan and unassigned ouuan Apr 28, 2020
@ouuan
Copy link
Member

ouuan commented May 3, 2020

@allcontributors add @GoBigorGoHome as a contributor for ideas.

@allcontributors
Copy link
Contributor

@ouuan

I've put up a pull request to add @GoBigorGoHome! 🎉

@ouuan ouuan modified the milestones: v6.4, v6.5 May 8, 2020
@ouuan ouuan added the work in progress The work has been started and is in progress. label May 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Harder than good first issues but not too hard for newcomers, and not assigned to any maintainer high_priority High Priority Issues are marked with this label. preferences Something related to the preferences work in progress The work has been started and is in progress.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants