Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icon tooltip is not localized #4

Closed
fkaelberer opened this issue Aug 19, 2018 · 4 comments
Closed

Icon tooltip is not localized #4

fkaelberer opened this issue Aug 19, 2018 · 4 comments

Comments

@fkaelberer
Copy link
Contributor

grafik

  • Expected behavior: Icon tooltip text is the same as in the right-click menu ("Seite in privatem Fenster öffnen")
  • Actual behavior: English text is shown.

(I hope the tooltip icon isn't just saying the name of the addon because the tooltips of all other icons are describing the corresponding action.)

@cpeterso
Copy link
Owner

Thanks for the bug report. The tooltip ought to be localized like the right-click menu item. I should fix that.

I hope the tooltip icon isn't just saying the name of the addon because the tooltips of all other icons are describing the corresponding action.

What tooltip description would you like to see? In English, "Open Page in Private Window" is both the extension name and the action. 😃

@fkaelberer
Copy link
Contributor Author

What tooltip description would you like to see?

The right-click menu entry translation is just fine (It's the direct translation of "Open Page in Private Window").

@cpeterso
Copy link
Owner

I published a new extension version (v1.0.0!) that should uses the same localized string for the context menu item and the toolbar icon's tooltip. I didn't localize the extension name at this time. Are extension names commonly localized?

https://addons.mozilla.org/en-US/firefox/addon/open-page-in-private-window/versions/?page=1#version-1.0.0

Thanks again for reporting this bug!

@fkaelberer
Copy link
Contributor Author

Translation is displayed fine now, but there was a grammatical error in the localization. See #7.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants