fix #50: browserify -s #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Cool. I agree - tests for the requirejs path would be helpful to ensure this remains stable. Thanks for the patch! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This apparently fixes #50 by using
browserify index.js -s dagreD3instead ofbrowserify browser.js. Looks like the tests pass!Since the IPython notebook was mentioned, and is what I wanted it for, I've made a notebook with an embedded build.
I don't know how to add testing require.js behavior to the test suite... there is some old doc about using r.js with karma, but I have never worked with it before. It could be that we can just trust browserify, which is usually smarter than me, but I would kind of like to know that this was being looked after.
There are some warnings on the browsersify doc related to how this might affect downstream builds that are explicitly looking for
require... I also don't know how to test that until it breaks someone's stuff.Hopefully this helps!