Redo: Add css class to edge, if they have that attribute set #151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This behaves inconsistently with create-nodes. I'll take the PR if we can get it in sync, which should be a matter of using util.applyClass and adding tests to bundle-test.js. |
Adds tests for class on edges.
|
Good point. I changed the behaviour to be consistent. The css classes are applied on the group object which also has the "edgePath" class. I also added tests for that. |
cpettitt
added a commit
that referenced
this pull request
Mar 31, 2015
Add css class to edge, if they have that attribute set
|
Thanks! I'll get a build out shortly. |
|
Published in https://github.com/cpettitt/dagre-d3/releases/tag/v0.4.3. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since there has been no progress on PR #145, I redid the changes of ulilicht, because I think this is an important change to implement.