Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

p2c: Error when a null value is passed to a column that is not Nullable #1

Open
cpg314 opened this issue May 22, 2024 · 0 comments
Open

p2c: Error when a null value is passed to a column that is not Nullable #1

cpg314 opened this issue May 22, 2024 · 0 comments

Comments

@cpg314
Copy link
Owner

cpg314 commented May 22, 2024

https://github.com/cpg314/polarhouse/blob/main/src/p2c.rs#L118
Right now we are mapping a polars null to a Clickhouse null, which is apparently transformed to the type's default value by the server.
Instead, we should trigger an error.
@cpg314 cpg314 changed the title p2c: Error when a null value is pass to a column that is not Nullable p2c: Error when a null value is passed to a column that is not Nullable May 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@cpg314