Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Health 3.3.0] parameter in method requestAuthorization to specify access permission #464

Closed
matsunanaro opened this issue Nov 26, 2021 · 2 comments
Closed

[Health 3.3.0] parameter in method requestAuthorization to specify access permission #464

matsunanaro opened this issue Nov 26, 2021 · 2 comments
Labels
improvement an improvement

Comments

@matsunanaro
Copy link

Description

The requestAuthorization method in HealthFactory should include a parameter to specify what permission is requested, e.g. READ ONLY, WRITE ONLY, READ_WRITE

Additional information

The current implementation is requesting implicitly both read and write access. However, an application may require only READ ACCESS in some scenarios. Implicitly requesting for both the permissions is not appropriate.
@matsunanaro matsunanaro added the improvement an improvement label Nov 26, 2021
@matsunanaro matsunanaro mentioned this issue Nov 26, 2021
Open
@rsbthebest
Copy link

Yup google has raised a OAuth issue for us because we are requesting write access while we don't really need it.

This was referenced Dec 3, 2021
Closed
Merged
Closed
@bardram
Copy link
Contributor

bardram commented Dec 29, 2021

This PR has been merged and published as version 3.4.0 of the plugin.

@bardram bardram closed this as completed Dec 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
improvement an improvement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@bardram @rsbthebest @matsunanaro