Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Informed Consent should not decide what happens when we click cancel #82

Open
LarsRefsgaard opened this issue May 25, 2023 · 2 comments
Open

Informed Consent should not decide what happens when we click cancel #82

LarsRefsgaard opened this issue May 25, 2023 · 2 comments
Assignees
@bardram
Labels
invalid This doesn't seem right question Further information is requested

Comments

@LarsRefsgaard
Copy link

LarsRefsgaard commented May 25, 2023 •
edited

in /src/ui/RPUITask.dart line 202-204
Navigator.of(context).pop(), // Dismissing the pop-up
needs to be revised to be customisable or something, because in the Study app we are not pushing the UI on top, but rather moving to that part of the onboarding process UI.
@LarsRefsgaard LarsRefsgaard mentioned this issue May 26, 2023
Closed
33 tasks
@bardram
Copy link
Contributor

bardram commented Jun 13, 2023

I'm not sure this is correct. Everything in RP builds upon the assumption that you push any RPUITask on top of the app.

@bardram bardram self-assigned this Jun 13, 2023
@bardram bardram added invalid This doesn't seem right question Further information is requested labels Jun 13, 2023
@LarsRefsgaard
Copy link
Author

Yes but it also assumes that the task UI is pushed, which might not be correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bardram bardram

Labels
invalid This doesn't seem right question Further information is requested
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bardram @LarsRefsgaard