Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor beats_hmm.pyx #51

Closed
superbock opened this issue Dec 9, 2015 · 1 comment
Closed

refactor beats_hmm.pyx #51

superbock opened this issue Dec 9, 2015 · 1 comment

Comments

@superbock
Copy link
Collaborator

There are numerous glitches in this module:

  1. no clear distinction of singular/plural; i.e. BeatTrackingStateSpace refers to a single beat to be modelled, whereas PatternTrackingStateSpace models multiple patterns.
  2. no way to model a bar with tempo transitions at the beat level
  3. very long class names, e.g. the "tracking" part could be removed completely
@superbock
Copy link
Collaborator Author

closing, since merge request #52 addressed all of the above issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@superbock