Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the hang on priority binding. #46

Merged
merged 1 commit into from
Mar 2, 2016
Merged

Conversation

cplotts
Copy link
Contributor

@cplotts cplotts commented Mar 2, 2016

This is a quick fix ... that addresses the hang that occurs when Snooping something that has a PriorityBinding. I wonder if there is a better way to fix this ... but let's merge this fix right away so that Snoop doesn't hang.

@cplotts cplotts mentioned this pull request Mar 2, 2016
cplotts added a commit that referenced this pull request Mar 2, 2016
Fixed the hang on priority binding.
@cplotts cplotts merged commit d50ae81 into master Mar 2, 2016
@cplotts cplotts deleted the hang-on-PriorityBinding branch March 2, 2016 23:25
@MaciekRakowski
Copy link
Contributor

It doesn't seem like a particularly "clean" fix, as a clean fix would probably mean rewriting the way we catch these events. 

On Wednesday, March 2, 2016 3:22 PM, Cory Plotts <notifications@github.com> wrote:

This is a quick fix ... that addresses the hang that occurs when Snooping something that has a PriorityBinding. I wonder if there is a better way to fix this ... but let's merge this fix right away so that Snoop doesn't hang.
You can view, comment on, or merge this pull request online at:
  #46
Commit Summary

  • Fixed the hang on priority binding.

File Changes

  • M Snoop/PropertyInformation.cs (2)

Patch Links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants