Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GB146 15.10 Add a feature-test macro for concepts P1902 #145

Closed
wg21bot opened this issue Oct 23, 2019 · 4 comments · Fixed by cplusplus/draft#3476
Closed

GB146 15.10 Add a feature-test macro for concepts P1902 #145

wg21bot opened this issue Oct 23, 2019 · 4 comments · Fixed by cplusplus/draft#3476
Labels
accepted concepts Concepts CWG Core
Projects
CWG
Milestone
CD C++20

Comments

@wg21bot
Copy link
Collaborator

wg21bot commented Oct 23, 2019

Concepts are missing a feature test macro
There is no feature test macro for the concepts language facility.

Proposed change:
Add a suitable definition of __cpp_concepts to [tab:cpp.predefined.ft]
@wg21bot wg21bot added CWG Core SG10 Feature-test macros labels Oct 23, 2019
@jfbastien jfbastien added the concepts Concepts label Oct 24, 2019
@brevzin brevzin mentioned this issue Oct 25, 2019
Closed
@jensmaurer jensmaurer changed the title GB146 15.10 Add a feature-test macro for concepts GB146 15.10 Add a feature-test macro for concepts P1902 Oct 25, 2019
@brevzin
Copy link
Collaborator

brevzin commented Nov 5, 2019

SG10 made a few changes to 1902, reaching consensus on the macros we want. A new draft can be found on the EWG and LEWG wikis.

@brevzin brevzin removed the SG10 Feature-test macros label Nov 5, 2019
@jensmaurer jensmaurer added EWG Evolution and removed CWG Core labels Nov 7, 2019
@jensmaurer
Copy link
Member

Assigning to EWG for a nod.

@jfbastien
Copy link
Collaborator

EWG on Thursday: Forward D1902 to CWG as a resolution to US150, GB147 and GB146, and let SG10 decide names for the macros

SF F N A SA
16 7 1 0 0

@jfbastien jfbastien added CWG Core and removed EWG Evolution labels Nov 7, 2019
@jensmaurer
Copy link
Member

CWG in Belfast: Accepted.

@jensmaurer jensmaurer added this to Accepted in CWG Nov 7, 2019
@burblebee burblebee mentioned this issue Nov 17, 2019
Merged
@jensmaurer jensmaurer added this to the CD C++20 milestone Sep 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
accepted concepts Concepts CWG Core
Projects
No open projects
CWG
Accepted
Milestone
CD C++20
Development

Successfully merging a pull request may close this issue.

LWG Motion 19: P1902R1 Missing feature-test macros 2017-2019 cplusplus/draft
4 participants
@jfbastien @brevzin @jensmaurer @wg21bot