Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

US212 20.07.3.1 [variant.ctor] Surprising variant construction LWG 3228 P1957 #209

Closed
wg21bot opened this issue Oct 24, 2019 · 10 comments · Fixed by cplusplus/draft#3729
Closed

US212 20.07.3.1 [variant.ctor] Surprising variant construction LWG 3228 P1957 #209

wg21bot opened this issue Oct 24, 2019 · 10 comments · Fixed by cplusplus/draft#3729
Labels
accepted CWG Core
Projects
CWG LWG
Milestone
CD C++20

Comments

@wg21bot
Copy link
Collaborator

wg21bot commented Oct 24, 2019 •
edited by jensmaurer
Loading

Resolve LWG 3228: surprising variant construction

Proposed change:
Resolve LWG 3228

See P1957 Converting from T* to bool should be considered narrowing (re: US 212) cplusplus/papers#692
@wg21bot wg21bot added the LWG Library label Oct 24, 2019
@wg21bot wg21bot changed the title US212 20.07.3.1 [variant.ctor] US212 20.07.3.1 [variant.ctor] Suprising variant construction LWG3228 Oct 24, 2019
@JeffGarland
Copy link
Member

Discussed in LWG small group in Belfast on Monday.

http://wg21.link/lwg3228

@mclow mclow added LEWG Library Evolution and removed LWG Library labels Nov 4, 2019
@mclow
Copy link

mclow commented Nov 4, 2019

Discussed in LWG on Monday afternoon in Belfast.
Referred to LEWG for design guidance (LWG3228 says "should it do (a), (b), or (c)?"

@mclow
Copy link

mclow commented Nov 5, 2019

D1957R0.html (on the LWG wiki) addresses this.

@tituswinters
Copy link

LEWG in Belfast: Forward D1957R0 to LWG and Core for C++20.

@tituswinters tituswinters added CWG Core LWG Library and removed LEWG Library Evolution labels Nov 7, 2019
@jensmaurer jensmaurer added this to TODO in CWG Nov 7, 2019
@jensmaurer
Copy link
Member

CWG in Belfast: Needs EWG review first.

@jensmaurer jensmaurer added EWG Evolution and removed CWG Core labels Nov 7, 2019
@jensmaurer jensmaurer moved this from TODO to Deferred for other group input in CWG Nov 7, 2019
@jensmaurer jensmaurer added this to Inbox in LWG Nov 7, 2019
@davidstone davidstone added CWG Core and removed EWG Evolution labels Nov 8, 2019
@davidstone
Copy link
Collaborator

EWG is fine with this change.

@jensmaurer jensmaurer moved this from Deferred for other group input to TODO in CWG Nov 8, 2019
@jensmaurer jensmaurer changed the title US212 20.07.3.1 [variant.ctor] Suprising variant construction LWG3228 US212 20.07.3.1 [variant.ctor] Suprising variant construction LWG 3228 P1957 Nov 8, 2019
@jensmaurer jensmaurer moved this from TODO to Drafting in CWG Nov 8, 2019
@jensmaurer
Copy link
Member

CWG in Belfast: Need to review again in Prague.

@jensmaurer jensmaurer moved this from Drafting to TODO in CWG Nov 9, 2019
@jensmaurer jensmaurer changed the title US212 20.07.3.1 [variant.ctor] Suprising variant construction LWG 3228 P1957 US212 20.07.3.1 [variant.ctor] Surprising variant construction LWG 3228 P1957 Jan 31, 2020
@jensmaurer jensmaurer moved this from TODO to Drafting in CWG Feb 10, 2020
@jensmaurer
Copy link
Member

CWG in Prague: Approved; needs LWG review.

@jensmaurer jensmaurer moved this from Drafting to Accepted in CWG Feb 11, 2020
@cplusplus cplusplus deleted a comment from JeffGarland Feb 11, 2020
@mclow
Copy link

mclow commented Feb 11, 2020

LWG has approved D1927R2 w/o changes. Removing LWG label

@mclow mclow removed the LWG Library label Feb 11, 2020
@mclow mclow moved this from Inbox to Accepted in LWG Feb 11, 2020
@jensmaurer
Copy link
Member

Accepted with modification. See paper P1927R2.

@jensmaurer jensmaurer mentioned this issue Feb 16, 2020
Merged
@jensmaurer jensmaurer added this to the CD C++20 milestone Sep 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
accepted CWG Core
Projects
No open projects
CWG
Accepted
LWG
Accepted
Milestone
CD C++20
Development

Successfully merging a pull request may close this issue.

CWG Poll 5: P1957R2 Converting from T* to bool should be considered narrowing cplusplus/draft
6 participants
@mclow @davidstone @JeffGarland @tituswinters @jensmaurer @wg21bot