Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LWG3714 Non-single-argument constructors for range adaptors should not be explicit #1257

Closed
jwakely opened this issue Jun 21, 2022 · 5 comments
Labels
B2 - improvement Bucket 2 as described by P0592: bug fixes, performance improvements, integration fixes for/between e C++23 Targeted at C++23 IS Ship vehicle: IS LEWG Library Evolution ranges std::ranges size - medium paper size estimate
Milestone

Comments

@jwakely
Copy link
Member

jwakely commented Jun 21, 2022

Issue: https://cplusplus.github.io/LWG/issue3714

During the LWG prioritization poll it was suggested that we need LEWG to decide on a consistent policy before we can make any consistency fix here. Please take a look and let us know what LEWG wants here.

@jwakely jwakely added LEWG Library Evolution ranges std::ranges IS Ship vehicle: IS B2 - improvement Bucket 2 as described by P0592: bug fixes, performance improvements, integration fixes for/between e size - tiny paper size estimate, smaller than small labels Jun 21, 2022
@brycelelbach brycelelbach added C++26 Targeted at C++26 ready-for-library-evolution-meeting-review This paper needs to be discussed at a Library Evolution meeting scheduled-for-library-evolution This paper has been scheduled for one of the groups: LEWG, LEWG Incubator, or a Mailing List review labels Jun 21, 2022
@billy-baker
Copy link
Collaborator

billy-baker commented Jul 19, 2022

2022-07-19 Library Evolution Telecon

LWG3714: Non-single-argument constructors for range adaptors should not be explicit

2022-07-19 Library Evolution Telecon Minutes

Chair: Billy Baker

Minute Taker:

Champion: Hewill Kang

Summary

The topic was presented in the LEWG 2022-07-19 telecon. For consistency, the views listed in the issue as well as views that are in flight such as P2374 cartesian_product_view need to be reviewed. There was some previous discussion on the topic of explicit constructors for P1899 stride_view. The issue has been referred to the Ranges Study group for guidance.

Next Steps

Send the issue to the Ranges study group for further review.

@brycelelbach brycelelbach added SG9 Ranges SG and removed LEWG Library Evolution ready-for-library-evolution-meeting-review This paper needs to be discussed at a Library Evolution meeting scheduled-for-library-evolution This paper has been scheduled for one of the groups: LEWG, LEWG Incubator, or a Mailing List review labels Aug 3, 2022
@inbal2l
Copy link
Collaborator

inbal2l commented Aug 8, 2022

Scheduled for SG9 on 10-10-2022 (Agenda)

@inbal2l
Copy link
Collaborator

inbal2l commented Oct 25, 2022

SG9 (Ranges) reviewed the issue on 2022-10-10, the review included Ville's paper on the same subject PXXXXR0: Ruminations on explicit multi-param constructors of views (Full Minutes).

Polls

POLL: We support applying “LWG3714: Non-single-argument constructors for range adaptors should not be explicit” AKA option 2 in Ville’s paper: “Drop the explicit from the C++23 views” to C++23 (possibly as an NB comment, if needed)

SF F N A SA
1 4 3 2 0

Attendance: 10

Author’s position: SF

Outcome: Weak recommendation in favor (no consensus)

POLL: We support apply option 1 in Ville’s paper: “Make the C++20 view multi-param constructors explicit too” to C++20

SF F N A SA
0 6 3 0 0

Attendance: 10

Author’s position: WF

Outcome: Consensus in favor

Summary

The second poll had more consensus. The polls indicate that SG9 support making the C++20 view multi-param constructors explicit (as a C++20 DR / Fix), recommendation is passed to LEWG.

@inbal2l inbal2l added LEWG Library Evolution and removed SG9 Ranges SG labels Oct 25, 2022
@brycelelbach brycelelbach added ready-for-library-evolution-meeting-review This paper needs to be discussed at a Library Evolution meeting scheduled-for-library-evolution This paper has been scheduled for one of the groups: LEWG, LEWG Incubator, or a Mailing List review labels Nov 2, 2022
@brycelelbach brycelelbach added C++23 Targeted at C++23 size - medium paper size estimate and removed C++26 Targeted at C++26 size - tiny paper size estimate, smaller than small labels Nov 10, 2022
@inbal2l
Copy link
Collaborator

inbal2l commented Nov 12, 2022

LEWG discussed this issue (along with P2711 Ruminations on explicit multi-param constructors of views) (full minutes) and decided to reject the resolution.

@brycelelbach brycelelbach removed ready-for-library-evolution-meeting-review This paper needs to be discussed at a Library Evolution meeting scheduled-for-library-evolution This paper has been scheduled for one of the groups: LEWG, LEWG Incubator, or a Mailing List review labels Jan 23, 2023
@brycelelbach
Copy link

@JeffGarland can you close this LWG issue, as we're proceeding with P2711.

@jensmaurer jensmaurer added this to the 2022-11 milestone Jan 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B2 - improvement Bucket 2 as described by P0592: bug fixes, performance improvements, integration fixes for/between e C++23 Targeted at C++23 IS Ship vehicle: IS LEWG Library Evolution ranges std::ranges size - medium paper size estimate
Projects
Development

No branches or pull requests

5 participants