Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

P2769 R1 get_element customization point object #1452

Open
wg21bot opened this issue Jan 16, 2023 · 7 comments
Open

P2769 R1 get_element customization point object #1452

wg21bot opened this issue Jan 16, 2023 · 7 comments
Labels
B2 - improvement Bucket 2 as described by P0592: bug fixes, performance improvements, integration fixes for/between e C++26 Targeted at C++26 IS Ship vehicle: IS LEWG Library Evolution needs-revision Paper needs changes before it can proceed size - medium paper size estimate

Comments

@wg21bot
Copy link
Collaborator

wg21bot commented Jan 16, 2023

P2769R0 get_element customization point object (Ruslan Arutyunyan, Alexey Kukanov)

@wg21bot wg21bot added LEWG Library Evolution SG9 Ranges SG labels Jan 16, 2023
@wg21bot wg21bot added this to the 2022-telecon milestone Jan 16, 2023
@brycelelbach brycelelbach added B2 - improvement Bucket 2 as described by P0592: bug fixes, performance improvements, integration fixes for/between e IS Ship vehicle: IS C++26 Targeted at C++26 size - medium paper size estimate ready-for-library-evolution-meeting-review This paper needs to be discussed at a Library Evolution meeting labels Jan 23, 2023
@inbal2l
Copy link
Collaborator

inbal2l commented Jan 24, 2023

Scheduled for SG9 meeting in Issaquah (Monday afternoon).

@brycelelbach brycelelbach removed the LEWG Library Evolution label Jan 25, 2023
@brycelelbach
Copy link

@inbal2l Y'all look at this first and then send it to us.

@inbal2l
Copy link
Collaborator

inbal2l commented Feb 7, 2023

SG9 (Ranges) reviewed the paper on 2023-02-06 (Full Minutes).

The paper needs additional revision, to explore potential alternative designs and implementation impact

Polls

POLL: The solution proposed in the paper “P2769: get_element customization point object” should be renamed to “std::ranges::get”.

SF F N A SA
1 2 1 2 1

Attendance: 31

# of Authors: 1

Author Position: SF

Outcome: No Consensus

IL: We need more information - the author should explore if the change will be an ABI break (or not, as suggested by an implementer during the discussion), and which exact use cases will be broken.

POLL: The solution proposed in the paper “P2769: get_element customization point object” should be moved out of the “ranges” namespace (std::get_element”).

SF F N A SA
2 4 0 1 0

Attendance: 20

# of Authors: 1

Author Position: F

Outcome: Consensus in favor

A: I would prefer seeing this solved by a more broad-range solution in std::

Summary

The paper needs additional revision.

(Chair note: after discussing with the authors of P2547, we suspect there's no reason to avoid this additional CPO, it will be one of many which will need to be addressed if P2547 is accepted)

@brycelelbach brycelelbach added LEWG Library Evolution needs-revision Paper needs changes before it can proceed labels Feb 10, 2023
@inbal2l inbal2l removed the SG9 Ranges SG label Feb 18, 2023
@jensmaurer jensmaurer removed this from the 2023-02 milestone Mar 31, 2023
@cor3ntin cor3ntin removed the ready-for-library-evolution-meeting-review This paper needs to be discussed at a Library Evolution meeting label May 3, 2023
@brycelelbach brycelelbach added SG9 Ranges SG and removed LEWG Library Evolution needs-revision Paper needs changes before it can proceed labels May 24, 2023
@brycelelbach
Copy link

P2769R1 will be available in the 2023-05 mailing.

@wg21bot wg21bot added this to the 2023-telecon milestone May 26, 2023
@wg21bot wg21bot changed the title P2769 get_element customization point object P2769 R1 get_element customization point object May 26, 2023
@dhollman
Copy link
Collaborator

@inbal2l would you like me to schedule this for Kona? Does R1 need to be reviewed by SG9, or were the revisions aimed at LEWG?

@inbal2l
Copy link
Collaborator

inbal2l commented Dec 6, 2023

R0 of the paper was seen by SG9 (as it was targeting < ranges >). Changes were applied, and R1 was reviewed and approved by the SG9 chair, who saw no need for this to be seen again by SG9 and forwarded it to LEWG.

@inbal2l inbal2l removed the SG9 Ranges SG label Dec 6, 2023
@inbal2l inbal2l added LEWG Library Evolution ready-for-library-evolution-meeting-review This paper needs to be discussed at a Library Evolution meeting labels Dec 6, 2023
@inbal2l inbal2l added the scheduled-for-library-evolution This paper has been scheduled for one of the groups: LEWG, LEWG Incubator, or a Mailing List review label Jan 5, 2024
@ben-craig
Copy link
Collaborator

2024-01-23 Library Evolution Telecon

P2769R1: get_element customization point object

2024-01-23 Library Evolution Telecon Minutes

Champion: Ruslan Arutyunyan

Chair: Ben Craig

Minute Taker: Eddie Nolan

Summary

POLL: P2769R1 (get_element customization point object) needs to allow for user tuple-likes before it can ship

SF F N A SA
3 3 4 2 0

Attendance: 21

# of Authors: 1

Author's Position: N

Outcome: Weak consensus

Comments: WA: Value in providing simple projection without necessarily going for the general solution. May be easier to understand if the facility had a less general name.

POLL: LEWG should spend more time on P2769R1 (get_element customization point object)

SF F N A SA
5 4 0 2 0

Attendance: 21

# of Authors: 1

Author's Position: SF

Outcome: Consensus in favor

Comments: WA: Current paper has wrong motivation. Language solution would be better. Customization point problem seems fine, but that's not this paper.

Next Steps

Come back with another revision that allows for user tuple-likes

p2165r2 has some wording for a generalised tuple_like (and that was approved by LEWG)

@ben-craig ben-craig added needs-revision Paper needs changes before it can proceed and removed ready-for-library-evolution-meeting-review This paper needs to be discussed at a Library Evolution meeting scheduled-for-library-evolution This paper has been scheduled for one of the groups: LEWG, LEWG Incubator, or a Mailing List review labels Jan 23, 2024
@jensmaurer jensmaurer removed this from the 2023-telecon milestone Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B2 - improvement Bucket 2 as described by P0592: bug fixes, performance improvements, integration fixes for/between e C++26 Targeted at C++26 IS Ship vehicle: IS LEWG Library Evolution needs-revision Paper needs changes before it can proceed size - medium paper size estimate
Projects
None yet
Development

No branches or pull requests

7 participants