Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[reflect.synopsis] 21.12.4.2: unpack_sequence_t is a variable template initialized by a type (Needs NB Comment) #17

Closed
Dani-Hub opened this issue Aug 11, 2018 · 1 comment

Comments

@Dani-Hub
Copy link
Member

This is not a review deviation of the accepted p0670r4 document but was observed during the review:

In [reflect.synopsis], the template unpack_sequence_t is defined as follows:

template <template <class...> class Tpl, ObjectSequence T>
constexpr auto unpack_sequence_t = unpack_sequence<Tpl, T>::type;

but according to [reflect.ops.objseq] p3:

All specializations of unpack_sequence<Tpl, T> shall meet the TransformationTrait requirements
(23.15.1). The nested type named type is an alias to the template Tpl specialized
with the types in T.

So it seems that what unpack_sequence_t actually defines would be a type alias instead of a variable template and should be corrected to

template <template <class...> class Tpl, ObjectSequence T>
using unpack_sequence_t = typename unpack_sequence<Tpl, T>::type;
@camio camio changed the title [reflect.synopsis] 21.12.4.2: unpack_sequence_t is a variable template initialized by a type [reflect.synopsis] 21.12.4.2: unpack_sequence_t is a variable template initialized by a type (Needs NB Comment) Aug 12, 2018
@Axel-Naumann
Copy link
Contributor

Resolved, @camio ?

@camio camio closed this as completed Feb 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants