Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

State what python version is used in README #185

Closed
2bndy5 opened this issue Jan 31, 2024 · 8 comments · Fixed by #187
Closed

State what python version is used in README #185

2bndy5 opened this issue Jan 31, 2024 · 8 comments · Fixed by #187
Labels
documentation Improvements or additions to documentation

Comments

@2bndy5
Copy link
Collaborator

2bndy5 commented Jan 31, 2024

One thing that would be nice to have in the README is that Python 3.10 needs to be installed in the docker image; that would extend the requirements and make it easier to understand.

Originally posted by @carlosala in #184 (comment) (edited for context by 2bndy5)

@2bndy5
Copy link
Collaborator Author

2bndy5 commented Jan 31, 2024

This information is exclusive to workflows that use docker images not maintained by GitHub. GitHub-maintained docker images (ubuntu-latest, windows-latest, and macos-latest) are already well enough equipped.

@shenxianpeng
Copy link
Collaborator

A stupid question, why do you have to specify version 3.11? because of this line?

python-version: '3.11'

What happens if other version?

@carlosala
Copy link
Contributor

Yep, setup-python as is set up only creates the structure and the binary is used afterwards, but it needs to have libpython3.11, for example, that should be installed in the system.

@2bndy5
Copy link
Collaborator Author

2bndy5 commented Feb 2, 2024

I just went with 3.11 because 3.12 recently turned "stable". For now, I have no reason to change that.

I suppose we could switch to whatever version ships with Ubuntu latest LTS release (which I think is currently 3.10).

@carlosala
Copy link
Contributor

carlosala commented Feb 2, 2024

Yep, latest LTS release is 3.10 https://packages.ubuntu.com/jammy/python3

@2bndy5
Copy link
Collaborator Author

2bndy5 commented Feb 2, 2024

@shenxianpeng Any objections to changing python version to follow Ubuntu latest LTS? It tends to change every couple years in April.

@carlosala would that be preferable?

@carlosala
Copy link
Contributor

Much better, yes.

@shenxianpeng
Copy link
Collaborator

No, looks good to me

@2bndy5 2bndy5 changed the title State that python 3.11 is needed in README State what python version is used in README Feb 2, 2024
@shenxianpeng shenxianpeng added the documentation Improvements or additions to documentation label Feb 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants