Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: always run set-matrix to prevent locked up PRs on docs #613

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

NeroBurner
Copy link

@NeroBurner NeroBurner commented Sep 9, 2022

Letting set_matrix job run always, because it is required to report its status for an approved PR to be merged.

Fixes: #571

@NeroBurner NeroBurner added bug Something isn't working infrastructure Problems with the CI infrastructure or CI jobs labels Sep 9, 2022
Letting `set_matrix` job run always, because it is required to report its
status for an approved PR to be merged.

Fixes: #571
@NeroBurner
Copy link
Author

@rbsheth I don't know if this really works, but I can't approve my own PRs to test it

@rbsheth
Copy link
Member

rbsheth commented Sep 11, 2022

Hmm, I'm not sure if this will work as intended (and not trigger on every change to any file). How can we actually test this?

@NeroBurner
Copy link
Author

you could create a PR with just the current settings and I'll approve it. Then I can see if I could merge your PR with the set_matrix failed state. If I can do that, then this PR works as intended

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working infrastructure Problems with the CI infrastructure or CI jobs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docs only changes PRs can't be merged because of set_status job requirement
2 participants