Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alias templates are not qualified #587

Closed
alandefreitas opened this issue May 23, 2024 · 1 comment · Fixed by #608
Closed

Alias templates are not qualified #587

alandefreitas opened this issue May 23, 2024 · 1 comment · Fixed by #608
Assignees
Labels
Bug Something isn't working

Comments

@alandefreitas
Copy link
Collaborator

This issue has been split from #480 (Features missing for Boost.URL) as it turned out to be more complex than we initially thought.

Aliases are documented with the alias itself on the right-hand side: using error_category = error_category; (now they are using error_category = system::error_category;, which is not relative to the current alias namespace as in https://www.boost.org/doc/libs/master/libs/url/doc/html/url/ref/boost__urls__error_category.html.

I don't know if this has been completely fixed by @fpelliccioni's changes but we have to compare that with whatever doxygen does here.

@alandefreitas alandefreitas changed the title Review alias templates Review alias handlebars templates May 23, 2024
@alandefreitas alandefreitas added the Bug Something isn't working label May 24, 2024
@alandefreitas
Copy link
Collaborator Author

It seems like the original example, using error_category = error_category, is a little better now. It says system::error_category on the right-hand side. But we have other cases that are just as bad:

template<class T>
using optional = optional<T>;

We need to do what doxygen does here and we can try to be fancy later. In other words, just the fully qualified name on the right-hand side, and we call it a day.

@sdkrystian I'm assigning you here because I tried to fix this once and you had to revert it because I broke something else.

@alandefreitas alandefreitas changed the title Review alias handlebars templates Alias templates are not qualified May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants