Skip to content
This repository has been archived by the owner on Jun 25, 2020. It is now read-only.

Reload files changed outside of juCi++ #285

Closed
insunaa opened this issue Sep 9, 2016 · 3 comments
Closed

Reload files changed outside of juCi++ #285

insunaa opened this issue Sep 9, 2016 · 3 comments

Comments

@insunaa
Copy link
Contributor

insunaa commented Sep 9, 2016

When a file is changed outside of juCi++ the only way I found to reload the file was to close its tab in juCi++ and double click it in the tree view. Is it possible to add a menu-point / key-combo to reload the document that currently has the cursor?

If there already is one, I couldn't find it, if so, is it possible to make it more visible / obvious? Like for example putting a clickable label in the notification:

Caution: juci.cc was altered outside of juCi++ Click here to reload it

@insunaa
Copy link
Contributor Author

insunaa commented Sep 9, 2016

This is what I came up with:
insunaa@a1a0d92
I don't know if

Notebook::get().close_current();

is the right way to go and it probably needs to make sure that a warning flashes if you have unsaved changes. Some other things probably too but I can't think of them

Edit: derp. still has the debug std::cout<< in... I'll delete it in the next commit.
removed the offending part in this commit: insunaa@2fbf275

Edit2: Warning appears properly.

@eidheim
Copy link
Member

eidheim commented Sep 9, 2016

Thank you again, but sadly I'm quite busy till Tuesday and will not be able to look at new features till then (only have time for potential bugfixes).

@insunaa
Copy link
Contributor Author

insunaa commented Sep 9, 2016

Sure. It's not urgent ;)

Edit: If you want, I can just PR the commits I've made in my fork.

@insunaa insunaa mentioned this issue Sep 13, 2016
@eidheim eidheim closed this as completed Oct 5, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants