Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: Version detection #389

Closed
nuernbergerA opened this issue Oct 4, 2022 · 3 comments
Closed

Bug: Version detection #389

nuernbergerA opened this issue Oct 4, 2022 · 3 comments

Comments

@nuernbergerA
Copy link

valet update will always update due to version detection issues.

The latest git tags is "wrong" (missing 'v')
image

https://github.com/cpriego/valet-linux/blob/master/cli/valet.php#L21
is v2.2.32
latest tag = 2.2.35

Valet::onLatestVersion could trim the 'v' from the tag for comparison to prevent wrong tagging issues
@nuernbergerA
Copy link
Author

@Adesin-fr is there anything i can do to help?

@Adesin-fr
Copy link
Collaborator

Wow !
Shame on me !!
I'll fix it now !

@Adesin-fr
Copy link
Collaborator

@nuernbergerA Thanks for reporting,
I've made a new release, hope this fix this issue !

@nuernbergerA nuernbergerA mentioned this issue Jan 31, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Adesin-fr @nuernbergerA