Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conflict with scroll wheel #53

Closed
raoulvdberge opened this issue Mar 19, 2018 · 0 comments
Closed

Conflict with scroll wheel #53

raoulvdberge opened this issue Mar 19, 2018 · 0 comments

Comments

@raoulvdberge
Copy link

raoulvdberge commented Mar 19, 2018

I have an inventory that scrolls when using the scroll wheel.

I'm noticing that when I'm hovering over a slot while scrolling, that some scroll values (retrieved through Mouse.getEventDWheel()) are swallowed and are returning 0. This only happens when scrolling OVER a slot.

This makes scrolling harder: it takes more scrolling to get it to actually return a non-0 value.

This issue isn't present when Inventory Sorter isn't installed.

I did add the container AND the slot to the blacklist through IMC. While the scroller features are in fact disabled on the slot and container, it is still conflicting the mouse wheel.

The place where I'm calling Mouse.getEventDWheel() is in GuiScreen#handleMouseInput.

Relevant code:

Scrolling code (aka the Mouse.getEventDWheel() call):
https://github.com/raoulvdberge/refinedstorage/blob/mc1.12/src/main/java/com/raoulvdberge/refinedstorage/gui/GuiBase.java#L208-L217

IMC blacklisting call (in preInit):
https://github.com/raoulvdberge/refinedstorage/blob/mc1.12/src/main/java/com/raoulvdberge/refinedstorage/proxy/ProxyCommon.java#L228

https://github.com/raoulvdberge/refinedstorage/blob/mc1.12/src/main/java/com/raoulvdberge/refinedstorage/integration/inventorysorter/IntegrationInventorySorter.java

(The blacklisting works fine; the behavior is disabled, but it's still swallowing scroll values)

Thank you.

@cpw cpw closed this as completed in dd83140 Mar 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant