Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error : "TypeError: this.statusbar_buttons.push is not a function" #116

Closed

Conversation

haflinger
Copy link

@haflinger haflinger commented Jan 12, 2022

What does this implement/fix? Explain your changes.

When activating Pico-Go extension, the extension throw an error. To prevent this I have change the check from :

    if (this.statusbar_buttons == undefined || this.statusbar_buttons == '') {
          this.statusbar_buttons = ['status', 'connect', 'upload', 'download',
            'run', 'softreset'
          ];
    }

to :

    if (!Array.isArray(typeof this.statusbar_buttons)) {
      this.statusbar_buttons = ['status', 'connect', 'upload', 'download',
        'run', 'softreset'
      ];
    }

Does this close any currently open issues?

Close #113

Any relevant logs, error output, etc?

Capture d’écran 2022-01-12 à 09 18 22

Any other comments?

Where has this been tested?

Tested in VSC debugger.

Operating system: macOS Monterey 12.1

VSCode version: 1.63.2

Pico-Go version: 1.4.3

When vscode try to activate extension an error is throw.
@cpwood cpwood closed this Jun 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants