Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/async await #44

Merged
merged 34 commits into from Mar 3, 2021
Merged

Feature/async await #44

merged 34 commits into from Mar 3, 2021

Conversation

cpwood
Copy link
Owner

@cpwood cpwood commented Mar 3, 2021

What does this implement/fix? Explain your changes.

  • Uses ES6 Javascript throughout;
  • Removed callback spaghetti;
  • Removed redundant code;
  • Refactored serial comms code code;
  • Normalised naming conventions to PascalCase for classes and camelCase for methods and variables;
  • Uses let and const instead of var;
  • Semi-colons now used throughout;
  • Generally beautified code.

Does this close any currently open issues?

Fixes #35

@cpwood cpwood added the enhancement New feature or request label Mar 3, 2021
@cpwood cpwood added this to the v1.2.0 milestone Mar 3, 2021
@cpwood cpwood self-assigned this Mar 3, 2021
@cpwood cpwood merged commit ae25242 into develop Mar 3, 2021
@cpwood cpwood deleted the feature/async-await branch March 3, 2021 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
1 participant