Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

code duplication inside Program.g4 #390

Closed
yegor256 opened this issue Oct 23, 2021 · 6 comments
Closed

code duplication inside Program.g4 #390

yegor256 opened this issue Oct 23, 2021 · 6 comments
Assignees
Labels

Comments

@yegor256
Copy link
Member

This block contains duplicated code: https://github.com/cqfn/eo/blob/master/eo-parser/src/main/antlr4/org/eolang/parser/Program.g4#L131-L180 Would be great to get rid of duplication. I made it like this, after the discussion: https://stackoverflow.com/questions/64635366/how-to-make-antlr-consume-all-available-elements-using-recursion

@yegor256 yegor256 added the bug label Oct 23, 2021
@yegor256
Copy link
Member Author

@andreoss can you help here? budget=1h

@andreoss
Copy link
Member

@yegor256 Taken.

@yegor256
Copy link
Member Author

@andreoss it's done, I believe?

@andreoss
Copy link
Member

andreoss commented Aug 25, 2022

@yegor256 The structural duplication between application and htail remains, but many improvements had been done.
In #570, #611, #567, #563, which are PRs for this issue.

So this issue can be closed and replaced with a new one

@Graur
Copy link
Contributor

Graur commented Nov 14, 2022

@andreoss Did you finish this issue?

@yegor256
Copy link
Member Author

@andreoss @Graur I'm closing. I will submit new issues, if see more problems

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants