(#504) - Equality using byte representation #532

andreoss · 2021-12-24T11:56:15Z

Closes #504

Compare primitive types as bytes

yegor256 · 2021-12-25T11:03:24Z

eo-runtime/src/main/eo/org/eolang/bool.eo

+  [] > as-bytes
+    if. > @
+      ^
+      00-00-00-00-00-00-00-01


@andreoss I think bool must map to one byte, not eight

@yegor256 There is no way to do that without introducing narrowing casting to the language.
TRUE eq 1 and TRUE eq 01- would mean that 01- eq 1, which is not since 1 is 8 bytes.

@yegor256 Or bytes could ignore leading zeros when comparing bytes.

@andreoss this should be true: TRUE eq 01-, but this one false: TRUE eq 1

codecov · 2021-12-25T15:18:53Z

Codecov Report

Merging #532 (ff3e3f8) into master (106c2d8) will decrease coverage by 0.22%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master     #532      +/-   ##
============================================
- Coverage     81.29%   81.07%   -0.23%     
  Complexity      456      456              
============================================
  Files           131      126       -5     
  Lines          2400     2372      -28     
  Branches        216      216              
============================================
- Hits           1951     1923      -28     
  Misses          381      381              
  Partials         68       68

Impacted Files	Coverage Δ
...ime/src/main/java/EOorg/EOeolang/EObytes$EOeq.java	`100.00% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 106c2d8...ff3e3f8. Read the comment docs.

yegor256 · 2021-12-26T04:18:20Z

@andreoss see my comment above

yegor256 · 2021-12-27T05:19:05Z

@rultor merge

rultor · 2021-12-27T05:19:48Z

@rultor merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

rultor · 2021-12-27T05:29:15Z

@rultor merge

@andreoss @yegor256 Oops, I failed. You can see the full log here (spent 9min)

    at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:148)
    at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (LifecycleModuleBuilder.java:117)
    at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (LifecycleModuleBuilder.java:81)
    at org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build (SingleThreadedBuilder.java:56)
    at org.apache.maven.lifecycle.internal.LifecycleStarter.execute (LifecycleStarter.java:128)
    at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:305)
    at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:192)
    at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:105)
    at org.apache.maven.cli.MavenCli.execute (MavenCli.java:957)
    at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:289)
    at org.apache.maven.cli.MavenCli.main (MavenCli.java:193)
    at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
    at jdk.internal.reflect.NativeMethodAccessorImpl.invoke (NativeMethodAccessorImpl.java:62)
    at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke (DelegatingMethodAccessorImpl.java:43)
    at java.lang.reflect.Method.invoke (Method.java:566)
    at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced (Launcher.java:282)
    at org.codehaus.plexus.classworlds.launcher.Launcher.launch (Launcher.java:225)
    at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode (Launcher.java:406)
    at org.codehaus.plexus.classworlds.launcher.Launcher.main (Launcher.java:347)
Caused by: org.apache.maven.plugin.MojoFailureException: There are test failures.

Please refer to /home/r/repo/eo-runtime/target/surefire-reports for the individual test results.
Please refer to dump files (if any exist) [date].dump, [date]-jvmRun[N].dump and [date].dumpstream.
    at org.apache.maven.plugin.surefire.SurefireHelper.throwException (SurefireHelper.java:271)
    at org.apache.maven.plugin.surefire.SurefireHelper.reportExecution (SurefireHelper.java:159)
    at org.apache.maven.plugin.surefire.SurefirePlugin.handleSummary (SurefirePlugin.java:453)
    at org.apache.maven.plugin.surefire.AbstractSurefireMojo.executeAfterPreconditionsChecked (AbstractSurefireMojo.java:1175)
    at org.apache.maven.plugin.surefire.AbstractSurefireMojo.execute (AbstractSurefireMojo.java:932)
    at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo (DefaultBuildPluginManager.java:137)
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:210)
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:156)
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:148)
    at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (LifecycleModuleBuilder.java:117)
    at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (LifecycleModuleBuilder.java:81)
    at org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build (SingleThreadedBuilder.java:56)
    at org.apache.maven.lifecycle.internal.LifecycleStarter.execute (LifecycleStarter.java:128)
    at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:305)
    at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:192)
    at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:105)
    at org.apache.maven.cli.MavenCli.execute (MavenCli.java:957)
    at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:289)
    at org.apache.maven.cli.MavenCli.main (MavenCli.java:193)
    at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
    at jdk.internal.reflect.NativeMethodAccessorImpl.invoke (NativeMethodAccessorImpl.java:62)
    at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke (DelegatingMethodAccessorImpl.java:43)
    at java.lang.reflect.Method.invoke (Method.java:566)
    at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced (Launcher.java:282)
    at org.codehaus.plexus.classworlds.launcher.Launcher.launch (Launcher.java:225)
    at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode (Launcher.java:406)
    at org.codehaus.plexus.classworlds.launcher.Launcher.main (Launcher.java:347)
[ERROR] 
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR] 
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
[ERROR] 
[ERROR] After correcting the problems, you can resume the build with the command
[ERROR]   mvn <args> -rf :eo-runtime
container 88848340a2e25a79035d5340632eba2fd997aba4bbfd4578754c0c3d5c4aa7ed is dead
Mon Dec 27 06:29:08 CET 2021

yegor256 · 2021-12-27T14:24:51Z

@rultor merge

rultor · 2021-12-27T14:26:15Z

@rultor merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

rultor · 2021-12-27T14:36:48Z

@rultor merge

@yegor256 Done! FYI, the full log is here (took me 10min)

0crat · 2022-01-16T18:55:04Z

@yegor256 /z everybody who has role REV is banned at #532; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

0crat · 2022-02-20T08:20:52Z

@yegor256 /z everybody who has role REV is banned at #532; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

(objectionary#504) - Equality compares by representation

5f7bfb5

0crat added 0crat/new and removed 0crat/new labels Dec 24, 2021

andreoss added 2 commits December 24, 2021 17:48

(objectionary#504) - Redefine bytes.eq

257e8fe

Merge remote-tracking branch 'upstream/master' into issue-504

a58c006

yegor256 reviewed Dec 25, 2021

View reviewed changes

(objectionary#504) - Remove eq-exact. Call as-bytes from eq

f1257c9

andreoss force-pushed the issue-504 branch from 0a47ca5 to 279ebe0 Compare December 25, 2021 15:14

Merge remote-tracking branch 'upstream/master' into issue-504

bf36048

andreoss force-pushed the issue-504 branch from 279ebe0 to bf36048 Compare December 25, 2021 15:32

andreoss marked this pull request as ready for review December 25, 2021 15:38

andreoss changed the title ~~(#504) - Equality compares by representation~~ (#504) - Equality using byte representation Dec 25, 2021

(objectionary#504) - Use one byte for BOOL

2da1e2d

andreoss added 2 commits December 27, 2021 07:31

Merge remote-tracking branch 'upstream/master' into issue-504

036964c

(objectionary#504) - Remove unneeded test

ff3e3f8

rultor merged commit ff3e3f8 into objectionary:master Dec 27, 2021

0crat removed the 0crat/scope label Feb 20, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

(#504) - Equality using byte representation #532

(#504) - Equality using byte representation #532

andreoss commented Dec 24, 2021

yegor256 Dec 25, 2021

andreoss Dec 25, 2021

andreoss Dec 25, 2021

yegor256 Dec 26, 2021

codecov bot commented Dec 25, 2021 •

edited

yegor256 commented Dec 26, 2021

yegor256 commented Dec 27, 2021

rultor commented Dec 27, 2021

rultor commented Dec 27, 2021

yegor256 commented Dec 27, 2021

rultor commented Dec 27, 2021

rultor commented Dec 27, 2021

0crat commented Jan 16, 2022

0crat commented Feb 20, 2022

(#504) - Equality using byte representation #532

(#504) - Equality using byte representation #532

Conversation

andreoss commented Dec 24, 2021

yegor256 Dec 25, 2021

Choose a reason for hiding this comment

andreoss Dec 25, 2021

Choose a reason for hiding this comment

andreoss Dec 25, 2021

Choose a reason for hiding this comment

yegor256 Dec 26, 2021

Choose a reason for hiding this comment

codecov bot commented Dec 25, 2021 • edited

Codecov Report

yegor256 commented Dec 26, 2021

yegor256 commented Dec 27, 2021

rultor commented Dec 27, 2021

rultor commented Dec 27, 2021

yegor256 commented Dec 27, 2021

rultor commented Dec 27, 2021

rultor commented Dec 27, 2021

0crat commented Jan 16, 2022

0crat commented Feb 20, 2022

codecov bot commented Dec 25, 2021 •

edited