Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(#605) - Ensure INT represented as 8 bytes #608

Merged
merged 3 commits into from Mar 28, 2022

Conversation

andreoss
Copy link
Member

Per #605

  • Copy bytes with padding when converting to INT

@codecov
Copy link

codecov bot commented Mar 28, 2022

Codecov Report

Merging #608 (5b033f4) into master (1dfb810) will increase coverage by 0.24%.
The diff coverage is 90.32%.

@@             Coverage Diff              @@
##             master     #608      +/-   ##
============================================
+ Coverage     80.97%   81.22%   +0.24%     
- Complexity      509      516       +7     
============================================
  Files           143      143              
  Lines          2597     2610      +13     
  Branches        225      232       +7     
============================================
+ Hits           2103     2120      +17     
+ Misses          421      416       -5     
- Partials         73       74       +1     
Impacted Files Coverage Δ
eo-runtime/src/main/java/org/eolang/Param.java 72.91% <85.00%> (+14.29%) ⬆️
...rc/main/java/EOorg/EOeolang/EObytes$EOas_char.java 100.00% <100.00%> (ø)
...c/main/java/EOorg/EOeolang/EObytes$EOas_float.java 100.00% <100.00%> (+100.00%) ⬆️
...src/main/java/EOorg/EOeolang/EObytes$EOas_int.java 100.00% <100.00%> (ø)
...ime/src/main/java/EOorg/EOeolang/EObytes$EOor.java 100.00% <100.00%> (ø)
...rc/main/java/EOorg/EOeolang/EOchar$EOas_bytes.java 100.00% <100.00%> (ø)
...c/main/java/EOorg/EOeolang/EOfloat$EOas_bytes.java 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1dfb810...5b033f4. Read the comment docs.

@andreoss andreoss marked this pull request as ready for review March 28, 2022 02:18
@yegor256
Copy link
Member

@rultor merge

@rultor
Copy link
Contributor

rultor commented Mar 28, 2022

@rultor merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit 5b033f4 into objectionary:master Mar 28, 2022
@rultor
Copy link
Contributor

rultor commented Mar 28, 2022

@rultor merge

@yegor256 Done! FYI, the full log is here (took me 9min)

@0crat
Copy link

0crat commented Apr 2, 2022

@yegor256/z everybody who has role REV is banned at #608; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

@0crat
Copy link

0crat commented May 1, 2022

@yegor256/z everybody who has role REV is banned at #608; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

@0crat
Copy link

0crat commented May 6, 2022

@yegor256/z everybody who has role REV is banned at #608; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

@andreoss andreoss mentioned this pull request May 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants