-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Subject Not Required In Context Rx #18
Comments
Evidently not required in the prefetch either:
|
I don't believe this is an issue, especially for prefetch. Normally the prefetch is populated using the query string specified in the discovery response (see this example), which would require the subject to be specified for the specified resources. |
If the prefetch is empty then the patient in the hook request needs to be a valid PatientId, otherwise you have no way to search for other Rxs. Or, it might instead be required in the context Rx (it isn't currently). |
If the workflow is to first query all the Rx of the patient that are active (how is this computed? from the authoredOn date? This does not seem to be happening), then putting the active Rxs into the prefetch, it would seem the subject should be set in all of them. But checking? Not helpful for testing but I can do it if necessary. |
Well, subject is required by the MedicationRequest resource... I could add validation, but I am still unsure how valuable it would be. |
I wouldn't suggest validating the subject in any of the Rxs since they're not well formed without it and they would appear in the usual workflow (above). But if the prefetch is empty, where do you get the Patient.id from in the prefetch query? Is this coming from the hook.patient field? I can't find it in the code. |
Yes, it is coming from the request. Here is the code where the query string is built for medication-prescribe prefetch. |
I'm happy with the current implementation. Closing this issue now that my understanding is improved. Thanks |
It doesn't appear to be required. Is this ok? It certainly makes it simpler to write tests if its not needed. I'll check if its required in prefetch next and add a comment.
The text was updated successfully, but these errors were encountered: