Fix ./waf install

[htfy96]

Since default ./waf install only copies app into /usr/bin with broken libclang.so, we need to provide a customized build() in wscript.

Probably we can replace absolute rpath with relative one (e.g. libs/) and copies app, libclang.so and clang_resource_dir to /opt/cquery.

Current package on Arch Linux patched wscript to perform the above instructions, but I think it would be better to have these steps builtin in scripts. The directory structure is as follows:

/opt/cquery
├── clang_resource_dir
│   ├── include
│   └── README.md
├── cquery // with rpath=lib/
└── lib
    ├── BugpointPasses.so
    ├── libc++abi.so
    ├── libc++abi.so.1
    ├── libc++abi.so.1.0
    ├── libclang.so
    ├── libclang.so.4
    ├── libclang.so.4.0
    ├── libc++.so
    ├── libc++.so.1
    ├── libc++.so.1.0
    ├── libgomp.so
    ├── libiomp5.so
    ├── libLTO.so
    ├── libLTO.so.4
    ├── libLTO.so.4.0.0
    ├── libomp.so
    ├── libunwind.so
    ├── libunwind.so.1
    ├── libunwind.so.1.0
    └── LLVMHello.so

➜  cat /usr/bin/cquery 
#!/usr/bin/bash
cd /opt/cquery
./cquery $@

[jacobdufault]

IMHO I prefer not using ./waf install but I’m happy to merge any fixes so the Arch Linux script is simpler. Some wscript changes just got merged which change how libclang is used (#64) but I don't expect they will affect this issue in particular.

[MaskRay]

On Linux, the clang executable uses DT_RUNPATH to encode the search path of shared libraries .so it depends on.

% readelf -d Dev/llvm/build/bin/clang | grep RUNPATH
 0x000000000000001d (RUNPATH)            Library runpath: [$ORIGIN/../lib]

I'm not sure how Mac OS X and Windows work.

Ideally, the build directory reflects the file hierarchy that will be installed to the install prefix:

build
  bin
    cquery  (renamed from build/app)
  clang_resource_dir
  lib
    libclang.so.4
    libclang.so
    libclang.so.4.0

Then https://aur.archlinux.org/packages/cquery-git/ PKGBUILD can be simplified by just coping the directory contents to the system root.

[MaskRay]

What about:

build
  release
    bin
      cquery
    share          # not exist
      cquery
          clang_resource_dir
    lib                           # not exist
      cquery       
        libclang.so.4     # --bundled-clang=4.0.0
        libclang.so    # --bundled-clang=4.0.0
        libclang.so.4.0    # --bundled-clang=4.0.0

[MaskRay]

It appears to be fixed in recent waf improvement.