Documentation pipeline update #5
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cr333
requested changes
Jun 2, 2021
There was a problem hiding this comment.
Thanks for this, @reubenlindroos!
Apologies for the many comments. I hope they are not too hard to address.
One thing is unclear to me: why does this PR delete the demo images? Maybe it would help to rebase your branch on cr333/OmniPhotos or copy your changes over in a new branch?
docs/README.md
Outdated
|
|
||
| } | ||
| The `@brief` notation is not strictly necessary, only important for clarity. |
There was a problem hiding this comment.
clarity -> explicit
Co-authored-by: Christian Richardt <christian@richardt.name>
Co-authored-by: Christian Richardt <christian@richardt.name>
@cr333 I think the reason its deleting the images is because of the previous merge with the PR #7 . I'll have to be careful when merging. |
Co-authored-by: Christian Richardt <christian@richardt.name>
Co-authored-by: Christian Richardt <christian@richardt.name>
Co-authored-by: Christian Richardt <christian@richardt.name>
Co-authored-by: Christian Richardt <christian@richardt.name>
Co-authored-by: Christian Richardt <christian@richardt.name>
Co-authored-by: Christian Richardt <christian@richardt.name>
Co-authored-by: Christian Richardt <christian@richardt.name>
Co-authored-by: Christian Richardt <christian@richardt.name>
Co-authored-by: Christian Richardt <christian@richardt.name>
Co-authored-by: Christian Richardt <christian@richardt.name>
Co-authored-by: Christian Richardt <christian@richardt.name>
Co-authored-by: Christian Richardt <christian@richardt.name>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pipeline to automatically create documenation on read the docs using doxygen.
index.html(mainpage.hpp)