Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Circle Selector #9

Merged
merged 30 commits into from Sep 3, 2021
Merged

Circle Selector #9

merged 30 commits into from Sep 3, 2021

Conversation

reubenlindroos
Copy link
Collaborator

@reubenlindroos reubenlindroos commented Jun 24, 2021 •
edited

  • clean up requirements.txt
  • save plot of heatmaps to the cache/dataset directory.
  • move json file to capture directory
  • update the template with option to switch off circlefitting
  • update template to remove some of the options (e.g op_filename_expression)
  • Update README.md with automatic circle selection (section 2.2)
  • Update documentation for installation?
  • Linting (spacing), comment convention, Pep convention
  • sort imports
  • replace op_filename_epression with original_filename_expression

cv_utils

  • remove extra copy of computeColor
  • change pjoin to os.path.join
  • add more documentation for parameters in cv_utils (change lookatang to look_at_angle)
  • 'nxt' to 'next'
  • comment on line 100 (slice_equirect)

datatypes

  • more comments on some of the methods in PointDict

@cr333 cr333 marked this pull request as draft June 24, 2021 15:28
@reubenlindroos reubenlindroos changed the title Circlefitting Circle Selector Jul 5, 2021
@reubenlindroos reubenlindroos marked this pull request as ready for review July 27, 2021 09:32
cr333
cr333 requested changes Jul 29, 2021
View reviewed changes
Python/preprocessing/circleselector/cv_utils.py Outdated Show resolved Hide resolved
Python/preprocessing/abs_preprocessor.py Outdated Show resolved Hide resolved
Python/preprocessing/circleselector/cv_utils.py Outdated Show resolved Hide resolved
Python/preprocessing/circleselector/cv_utils.py Outdated Show resolved Hide resolved
Python/preprocessing/circleselector/cv_utils.py Outdated Show resolved Hide resolved
Python/preprocessing/config_omniphotos.sample.yaml Outdated Show resolved Hide resolved
Python/preprocessing/op_preprocessor.py Outdated Show resolved Hide resolved
Python/preprocessing/op_preprocessor.py Outdated Show resolved Hide resolved
Python/preprocessing/op_preprocessor.py Outdated Show resolved Hide resolved
Python/preprocessing/requirements.txt Outdated Show resolved Hide resolved
reubenlindroos
reubenlindroos commented Sep 3, 2021
View reviewed changes
Python/preprocessing/circleselector/datatypes.py Outdated Show resolved Hide resolved
Python/preprocessing/circleselector/datatypes.py Outdated Show resolved Hide resolved
Python/preprocessing/op_preprocessor.py Show resolved Hide resolved
Python/preprocessing/readme.md Outdated Show resolved Hide resolved
@reubenlindroos reubenlindroos merged commit 0284b65 into main Sep 3, 2021
@reubenlindroos reubenlindroos deleted the circlefitting branch September 3, 2021 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cr333 cr333 cr333 requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@reubenlindroos @cr333