Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ${GeographicLib_LIBRARIES} to navsat_transform #617

Merged
merged 1 commit into from
Jan 14, 2021
Merged

Add ${GeographicLib_LIBRARIES} to navsat_transform #617

merged 1 commit into from
Jan 14, 2021

Conversation

Tobias-Fischer
Copy link

Otherwise this leads to a linker error on Windows:

navsat_transform.cpp.obj : error LNK2019: unresolved external symbol "__declspec(dllimport) public: static class GeographicLib::Geocentric const & __cdecl GeographicLib::Geocentric::WGS84(void)" (__imp_?WGS84@Geocentric@GeographicLib@@SAAEBV12@XZ) referenced in function "public: __cdecl RobotLocalization::NavSatTransform::NavSatTransform(class ros::NodeHandle,class ros::NodeHandle)" (??0NavSatTransform@RobotLocalization@@QEAA@VNodeHandle@ros@@0@Z)
navsat_transform.cpp.obj : error LNK2019: unresolved external symbol "__declspec(dllimport) private: void __cdecl GeographicLib::LocalCartesian::IntForward(double,double,double,double &,double &,double &,double * const)const " (__imp_?IntForward@LocalCartesian@GeographicLib@@AEBAXNNNAEAN00QEAN@Z) referenced in function "private: bool __cdecl RobotLocalization::NavSatTransform::fromLLCallback(struct robot_localization::FromLLRequest_<class std::allocator<void> > &,struct robot_localization::FromLLResponse_<class std::allocator<void> > &)" (?fromLLCallback@NavSatTransform@RobotLocalization@@AEAA_NAEAU?$FromLLRequest_@V?$allocator@X@std@@@robot_localization@@AEAU?$FromLLResponse_@V?$allocator@X@std@@@4@@Z)
navsat_transform.cpp.obj : error LNK2019: unresolved external symbol "__declspec(dllimport) private: void __cdecl GeographicLib::LocalCartesian::IntReverse(double,double,double,double &,double &,double &,double * const)const " (__imp_?IntReverse@LocalCartesian@GeographicLib@@AEBAXNNNAEAN00QEAN@Z) referenced in function "private: void __cdecl RobotLocalization::NavSatTransform::mapToLL(class tf2::Vector3 const &,double &,double &,double &)const " (?mapToLL@NavSatTransform@RobotLocalization@@AEBAXAEBVVector3@tf2@@AEAN11@Z)
navsat_transform.cpp.obj : error LNK2019: unresolved external symbol "__declspec(dllimport) public: void __cdecl GeographicLib::LocalCartesian::Reset(double,double,double)" (__imp_?Reset@LocalCartesian@GeographicLib@@QEAAXNNN@Z) referenced in function "public: __cdecl RobotLocalization::NavSatTransform::NavSatTransform(class ros::NodeHandle,class ros::NodeHandle)" (??0NavSatTransform@RobotLocalization@@QEAA@VNodeHandle@ros@@0@Z)

It makes sense as navsat_transform.h pulls in #include <GeographicLib/Geocentric.hpp>.

This patch fixes it.

Copy link
Collaborator

@SteveMacenski SteveMacenski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noetic is Tom's domain but LGTM

Copy link
Collaborator

@ayrton04 ayrton04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ayrton04 ayrton04 merged commit e550b39 into cra-ros-pkg:noetic-devel Jan 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants