SHARED linking for Geographiclib #624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acxz
reviewed
Feb 21, 2021
CMakeLists.txt
Outdated
| @@ -34,7 +34,7 @@ endif() | |||
|
|
|||
| # Geographiclib installs FindGeographicLib.cmake to this non-standard location | |||
| set(CMAKE_MODULE_PATH ${CMAKE_MODULE_PATH} "/usr/share/cmake/geographiclib/") | |||
| find_package(GeographicLib REQUIRED COMPONENTS STATIC) | |||
| find_package(GeographicLib REQUIRED COMPONENTS SHARED) | |||
There was a problem hiding this comment.
Is there a way to just remove the explicit STATIC/SHARED dependency on the line?
Something like just
Suggested change
| find_package(GeographicLib REQUIRED COMPONENTS SHARED) | |
| find_package(GeographicLib REQUIRED) |
ayrton04
reviewed
Feb 22, 2021
| @@ -34,7 +34,7 @@ endif() | |||
|
|
|||
| # Geographiclib installs FindGeographicLib.cmake to this non-standard location | |||
| set(CMAKE_MODULE_PATH ${CMAKE_MODULE_PATH} "/usr/share/cmake/geographiclib/") | |||
| find_package(GeographicLib REQUIRED COMPONENTS STATIC) | |||
| find_package(GeographicLib REQUIRED) | |||
There was a problem hiding this comment.
@AGummyBear Was there any reason for the static linkage previously?
There was a problem hiding this comment.
My thinking was just that it would result in not needing to install GeographicLib as a dependency unless building, since I think most users are probably running this package as installed. I'm fine with the change to shared though. There was no technical reason to use static.
ayrton04
pushed a commit
that referenced
this pull request
Jun 3, 2021
* remove GeographicLib specific linking option
sundermann
pushed a commit
to sundermann/robot_localization
that referenced
this pull request
Jan 6, 2022
* remove GeographicLib specific linking option
sundermann
pushed a commit
to sundermann/robot_localization
that referenced
this pull request
Jan 6, 2022
* remove GeographicLib specific linking option
This was referenced Jan 6, 2022
SteveMacenski
pushed a commit
that referenced
this pull request
Jan 7, 2022
SteveMacenski
pushed a commit
that referenced
this pull request
Jan 7, 2022
tonynajjar
added a commit
to logivations/robot_localization
that referenced
this pull request
Apr 26, 2022
* SHARED linking for Geographiclib (cra-ros-pkg#624) (cra-ros-pkg#713) * remove GeographicLib specific linking option Co-authored-by: Achmad Fathoni <fathoni.id@gmail.com> * Fixing code style divergence for ament_uncrustify (cra-ros-pkg#742) * Fixed state history reversion (cra-ros-pkg#736) Co-authored-by: Zygfryd Wieszok <zwieszok@autonomous-systems.pl> * Read predict_to_current_time from ROS parameters (cra-ros-pkg#737) Co-authored-by: Zygfryd Wieszok <zwieszok@autonomous-systems.pl> * Using angles library to normalize angles (cra-ros-pkg#739) * Using angles library for innovation angle normalization Co-authored-by: Stephan Sundermann <stephansundermann@gmail.com> Co-authored-by: Achmad Fathoni <fathoni.id@gmail.com> Co-authored-by: Anish <anishgdev@gmail.com> Co-authored-by: Zygfryd Wieszok <zygfryd.wieszok@gmail.com> Co-authored-by: Zygfryd Wieszok <zwieszok@autonomous-systems.pl> Co-authored-by: Marek Piechula <marpiechula@gmail.com>
tonynajjar
added a commit
to logivations/robot_localization
that referenced
this pull request
Apr 26, 2022
* SHARED linking for Geographiclib (cra-ros-pkg#624) (cra-ros-pkg#713) * remove GeographicLib specific linking option Co-authored-by: Achmad Fathoni <fathoni.id@gmail.com> * Fixing code style divergence for ament_uncrustify (cra-ros-pkg#742) * Fixed state history reversion (cra-ros-pkg#736) Co-authored-by: Zygfryd Wieszok <zwieszok@autonomous-systems.pl> * Read predict_to_current_time from ROS parameters (cra-ros-pkg#737) Co-authored-by: Zygfryd Wieszok <zwieszok@autonomous-systems.pl> * Using angles library to normalize angles (cra-ros-pkg#739) * Using angles library for innovation angle normalization Co-authored-by: Stephan Sundermann <stephansundermann@gmail.com> Co-authored-by: Achmad Fathoni <fathoni.id@gmail.com> Co-authored-by: Anish <anishgdev@gmail.com> Co-authored-by: Zygfryd Wieszok <zygfryd.wieszok@gmail.com> Co-authored-by: Zygfryd Wieszok <zwieszok@autonomous-systems.pl> Co-authored-by: Marek Piechula <marpiechula@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Arch Linux doesn't install static library by default. So I made this PR for AUR package patch. It is OK if this PR is not eventually accepted.