-
Notifications
You must be signed in to change notification settings - Fork 666
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Page break support for type html #24
Comments
@EricLease Cool. I'll take a look at it as soon as I have a chance. |
Hey @EricLease , I had never take the time to look into this untill now. You branch looks great. I do however, want to keep using es6 |
I added support for page break with commit 163548d |
so i already read this and try to add css page-break as the same as @EricLease
but when i print it, it doesnt do the page-break. |
Hey @chocomail , did you create the class |
uhm okay, as when im using the codepen, i found the one making it not working the page-break is targetStyles. Am i doing it wrong?
okay i found it again, must insert
inside targetStyles, strangely enough, in my computer when i use |
Glad you figured it out. I'm not sure why |
I found the issue with |
Hey @crabbly , |
I have implemented basic page-break support for html printing in a branch (break-support) of my fork. The need arises from trying to control page-breaks when printing large sections of html.
I have tested this on Chrome, FF, and IE. Support for
page-break-*
andbreak-*
is not uniform across all browsers, and even more so when it comes to the supported values forpage-break-*
. In my case I have strict control over use ofpage-break-*/break-*
(I'm only usingalways
andavoid
), and I could see how a more robust implementation of this feature could become quite cumbersome. So this may not be a road you want to travel down, but just wanted to let you know it's there if you'd like to take a look. Let me know if you'd like a pull request.For cross-browser support of page breaks, for example, I would apply a class like the following:
The text was updated successfully, but these errors were encountered: